[v3-1-test] Improve startup information printed when Breeze starts (#58926) #58927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
…58926) We were using lru_cache to only print environment check output once, but the method was called once with quiet = False and once without, which made it double-print the output. The check was done in both - commmands and "docker_utils.enter_shell" and that was really unnecessary. This PR changes it so that environment check is done only once at the command entry, also the "executable bit" information that was somewhat useless is now replaced with printing a detailed version of Python used - which might help with diagnostics of some strange issues in case the output is copy&pasted. (cherry picked from commit 6c50b62) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
ephraimbuddy
force-pushed
the
backport-6c50b62-v3-1-test
branch
from
4281334 to
f887c9f
Compare
ephraimbuddy
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil and
potiuk
as code owners
jason810496
approved these changes
Dec 2, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…58926) (#58927) We were using lru_cache to only print environment check output once, but the method was called once with quiet = False and once without, which made it double-print the output. The check was done in both - commmands and "docker_utils.enter_shell" and that was really unnecessary. This PR changes it so that environment check is done only once at the command entry, also the "executable bit" information that was somewhat useless is now replaced with printing a detailed version of Python used - which might help with diagnostics of some strange issues in case the output is copy&pasted. (cherry picked from commit 6c50b62) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using lru_cache to only print environment check output once,
but the method was called once with quiet = False and once without,
which made it double-print the output.
The check was done in both - commmands and "docker_utils.enter_shell"
and that was really unnecessary.
This PR changes it so that environment check is done only once at
the command entry, also the "executable bit" information that was
somewhat useless is now replaced with printing a detailed version
of Python used - which might help with diagnostics of some strange
issues in case the output is copy&pasted.
(cherry picked from commit 6c50b62)
Co-authored-by: Jarek Potiuk jarek@potiuk.com