Skip to content

[v3-1-test] Improve startup information printed when Breeze starts (#58926) #58927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ephraimbuddy merged 1 commit into from
Dec 2, 2025
Merged

[v3-1-test] Improve startup information printed when Breeze starts (#58926) #58927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dev/breeze/src/airflow_breeze/commands/developer_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ def shell(
verbose_commands=verbose_commands,
warn_image_upgrade_needed=warn_image_upgrade_needed,
)
perform_environment_checks()
perform_environment_checks(quiet=shell_params.quiet)
rebuild_or_pull_ci_image_if_needed(command_params=shell_params)
result = enter_shell(shell_params=shell_params)
fix_ownership_using_docker()
Expand Down Expand Up @@ -701,6 +701,7 @@ def start_airflow(
use_uv=use_uv,
uv_http_timeout=uv_http_timeout,
)
perform_environment_checks(quiet=shell_params.quiet)
rebuild_or_pull_ci_image_if_needed(command_params=shell_params)
result = enter_shell(shell_params=shell_params)
fix_ownership_using_docker()
Expand Down
6 changes: 4 additions & 2 deletions dev/breeze/src/airflow_breeze/utils/docker_command_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def check_executable_entrypoint_permissions(quiet: bool = False):
f"repository should only be checked out on a filesystem that is POSIX compliant."
)
sys.exit(1)
if not quiet:
if get_verbose() and not quiet:
get_console().print("[success]Executable permissions on entrypoints are OK[/]")


Expand All @@ -542,6 +542,8 @@ def perform_environment_checks(quiet: bool = False):
check_docker_version(quiet)
check_docker_compose_version(quiet)
check_executable_entrypoint_permissions(quiet)
if not quiet:
get_console().print(f"[success]Host python version is {sys.version}[/]")


def get_docker_syntax_version() -> str:
Expand Down Expand Up @@ -810,6 +812,7 @@ def execute_command_in_shell(
shell_params.extra_args = (command,)
if get_verbose():
get_console().print(f"[info]Command to execute: '{command}'[/]")
perform_environment_checks(quiet=shell_params.quiet)
return enter_shell(shell_params, output=output, signal_error=signal_error)


Expand All @@ -827,7 +830,6 @@ def enter_shell(
* shuts down existing project
* executes the command to drop the user to Breeze shell
"""
perform_environment_checks(quiet=shell_params.quiet)
fix_ownership_using_docker(quiet=shell_params.quiet)
cleanup_python_generated_files()
if read_from_cache_file("suppress_asciiart") is None and not shell_params.quiet:
Expand Down
Loading