Skip to content

Conversation

@mrrsm
Copy link
Contributor

@mrrsm mrrsm commented Dec 4, 2025

Description

This will add the ability to set pod disruption budget resources for either the triggerer and/or worker pods. These are disabled by default as to not cause a breaking change in the helm chart.

Why

We are running multiple instances of triggerer pods as well as worker pods. When we have a cluster event that may take out a node having the PDB allows us to not have multiple instances of the same pods go down at the same time.


@boring-cyborg
Copy link

boring-cyborg bot commented Dec 4, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Dec 4, 2025
@mrrsm mrrsm force-pushed the add-pdbs branch 2 times, most recently from e7c54a9 to f9cdf54 Compare December 5, 2025 14:25
@Miretpl
Copy link
Contributor

Miretpl commented Dec 5, 2025

Hi @mrrsm, could you add a test cases?

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I think this makes sense and per default it is disabled which is fine. I am not sure when enabled that the defautls are also fine but depends very much on the deployment and scope.

I approve and keep it open for 1-2 days for another pair of eyes, else can be merged in my view.

@jscheffl jscheffl added this to the Airflow Helm Chart 1.19.0 milestone Dec 7, 2025
@jscheffl jscheffl changed the title fix(chart): Add pdbs for triggerer and workers Add pdbs for triggerer and workers Dec 7, 2025
Copy link
Contributor

@Miretpl Miretpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, small nits.

Also, one question to @jscheffl or/and @jedcunningham. PR #52357 introduced the workers.kubernetes and workers.celery sections. Changes in this PR will only affect the workers created by CeleryExecutor. So maybe this and similar new values should be placed under proper sections (maybe it is worth to discuss on devlist)? What do you think?

@mrrsm
Copy link
Contributor Author

mrrsm commented Dec 10, 2025

@Miretpl Thank you for the review/changes.

In an effort to not add a different way to do PDBs should I also update the PDB's and tests that already exist for other components (scheduler, api-server, etc) to match the style in this PR and also update the tests to remove the unneeded kubernetes version test?

@jscheffl jscheffl requested a review from Miretpl December 10, 2025 21:35
@Miretpl
Copy link
Contributor

Miretpl commented Dec 11, 2025

@mrrsm, consistency across the entire Helm Chart would be something nice to have, but I believe that combining everything in one PR can become a little harder to merge (based on my experience). Personally, I would probably do 2 additional PRs after this one:

  1. for making the PDB consistent between components
  2. removal of other unneeded tests, which are testing stuff for currently unsupported Kubernetes versions

@jscheffl
Copy link
Contributor

@Miretpl as of the updated, previously you requested changes - OK to merge? (In my view it is good)

Copy link
Contributor

@Miretpl Miretpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jscheffl in general looks good to me. I have just placed one comment that should resolve the tests. If they are green, we can merge it

@jscheffl jscheffl merged commit 1d99e8d into apache:main Dec 15, 2025
92 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 15, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@mrrsm mrrsm deleted the add-pdbs branch December 15, 2025 21:40
TempestShaw pushed a commit to TempestShaw/airflow that referenced this pull request Dec 24, 2025
* fix(chart): Add pdbs for triggerer and workers

* fix(chart): Add pdbs for triggerer and workers

* Update chart/templates/triggerer/triggerer-poddisruptionbudget.yaml

Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>

* Update chart/templates/triggerer/triggerer-poddisruptionbudget.yaml

Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>

* Update chart/templates/workers/worker-poddisruptionbudget.yaml

Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>

* fix: Remove unneeded tests

* Update chart/templates/triggerer/triggerer-poddisruptionbudget.yaml

Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>

---------

Co-authored-by: Przemysław Mirowski <miretpl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants