Skip to content

Conversation

@Miretpl
Copy link
Contributor

@Miretpl Miretpl commented Jun 27, 2025

related: #28880

This change is part of #51460, which introduces full separation in configuration between Kubernetes and Celery executors. Example implementation of full separation is done by introducing the workers.kubernetes and workers.celery sections, which can be used to overwrite the common workers section values. The separation of Service Accounts has a slightly different logic, as it does not allow for overwriting the common workers value by e.g. only celery section, so I decided to extract that part to this PR.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 27, 2025
@Miretpl Miretpl force-pushed the separate-workers-service-accounts branch from fde1734 to 9ca42ae Compare June 27, 2025 16:59
@Miretpl Miretpl force-pushed the separate-workers-service-accounts branch from 2b393a8 to 01aa0d5 Compare June 27, 2025 20:00
@Miretpl Miretpl marked this pull request as ready for review June 27, 2025 20:45
@Miretpl
Copy link
Contributor Author

Miretpl commented Jul 16, 2025

Hi @dstandish @jedcunningham @hussein-awala, could you take a look at this PR?

@potiuk potiuk merged commit 23d955d into apache:main Jul 18, 2025
71 checks passed
@eladkal eladkal added this to the Airflow Helm Chart 1.19.0 milestone Jul 18, 2025
karenbraganz pushed a commit to karenbraganz/airflow that referenced this pull request Jul 18, 2025
* Seperate workers service accounts for kubernetes and celery workers

* Add tests for new values

* Add better description of some fields
@Miretpl Miretpl deleted the separate-workers-service-accounts branch July 23, 2025 20:26
Miretpl added a commit to Miretpl/airflow that referenced this pull request Jan 17, 2026
jscheffl pushed a commit that referenced this pull request Jan 17, 2026
* Revert "Separate workers service accounts (#52357)"

This reverts commit 23d955d.

* Revert "Add newsfragment for 52357 PR (#59214)"

* Fix security tests
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
* Revert "Separate workers service accounts (apache#52357)"

This reverts commit 23d955d.

* Revert "Add newsfragment for 52357 PR (apache#59214)"

* Fix security tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants