Skip to content

Conversation

@choo121600
Copy link
Member

image

related: #59402


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Dec 15, 2025
@potiuk
Copy link
Member

potiuk commented Dec 16, 2025

Might be better to merge all those PRs in one:

a) they cause conflicts when one is merged
b) I think listing files individually in the hook make little sense, it would be better to do a module-bo module or at least have a number of those grouped together.

@choo121600
Copy link
Member Author

choo121600 commented Dec 16, 2025

Might be better to merge all those PRs in one:

a) they cause conflicts when one is merged b) I think listing files individually in the hook make little sense, it would be better to do a module-bo module or at least have a number of those grouped together.

I noticed that once one PR gets merged, the remaining PRs start to run into conflicts. I was initially unsure whether closing and reopening the PRs was the right approach, but I now think that might be the better option.

I also agree with point (b). This wasn’t something I fully considered when I first opened the PRs, but there are quite a lot of test files, and listing them individually in the hook would make it unnecessarily long. Grouping them at least by provider or by module seems more reasonable.

That said, there are already quite a few PRs open besides mine, so I’m not entirely sure what the best way forward is.

What do you think about closing the PRs I opened for now, reopen them as a grouped PR for airflow-core/tests(like #59501) and separate PRs per provider, and then, once everything is merged, reorganize the hook at the module level.
This way, we could also incorporate the work that other contributors have already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants