Skip to content

Refactor test_task_instances.py to use SQLA2 #59422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
choo121600 wants to merge 1 commit into from
Closed

Refactor test_task_instances.py to use SQLA2 #59422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,7 @@ repos:
^airflow-ctl.*\.py$|
^airflow-core/src/airflow/models/.*\.py$|
^airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_assets.py$|
^airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py$|
^task_sdk.*\.py$
pass_filenames: true
- id: update-supported-versions
Expand Down
20 changes: 10 additions & 10 deletions airflow-core/tests/unit/api_fastapi/execution_api/versions/head/test_task_instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1144,7 +1144,7 @@ def test_ti_update_state_to_deferred(self, client, session, create_task_instance

session.expire_all()

tis = session.query(TaskInstance).all()
tis = session.scalars(select(TaskInstance)).all()
assert len(tis) == 1

assert tis[0].state == TaskInstanceState.DEFERRED
Expand All @@ -1155,7 +1155,7 @@ def test_ti_update_state_to_deferred(self, client, session, create_task_instance
}
assert tis[0].trigger_timeout == timezone.make_aware(datetime(2024, 11, 23), timezone=timezone.utc)

t = session.query(Trigger).all()
t = session.scalars(select(Trigger)).all()
assert len(t) == 1
assert t[0].created_date == instant
assert t[0].classpath == "my-classpath"
Expand Down Expand Up @@ -1192,14 +1192,14 @@ def test_ti_update_state_to_reschedule(self, client, session, create_task_instan

session.expire_all()

tis = session.query(TaskInstance).all()
tis = session.scalars(select(TaskInstance)).all()
assert len(tis) == 1
assert tis[0].state == TaskInstanceState.UP_FOR_RESCHEDULE
assert tis[0].next_method is None
assert tis[0].next_kwargs is None
assert tis[0].duration == 129600

trs = session.query(TaskReschedule).all()
trs = session.scalars(select(TaskReschedule)).all()
assert len(trs) == 1
assert trs[0].task_instance.dag_id == "dag"
assert trs[0].task_instance.task_id == "test_ti_update_state_to_reschedule"
Expand Down Expand Up @@ -1273,11 +1273,11 @@ def test_ti_update_state_handle_retry(self, client, session, create_task_instanc
assert ti.next_method is None
assert ti.next_kwargs is None

tih = (
session.query(TaskInstanceHistory)
.where(TaskInstanceHistory.task_id == ti.task_id, TaskInstanceHistory.run_id == ti.run_id)
.one()
)
tih = session.scalars(
select(TaskInstanceHistory).where(
TaskInstanceHistory.task_id == ti.task_id, TaskInstanceHistory.run_id == ti.run_id
)
).one()
assert tih.task_instance_id
assert tih.task_instance_id != ti.id

Expand Down Expand Up @@ -1680,7 +1680,7 @@ def test_ti_put_rtif_success(self, client, session, create_task_instance, payloa

session.expire_all()

rtifs = session.query(RenderedTaskInstanceFields).all()
rtifs = session.scalars(select(RenderedTaskInstanceFields)).all()
assert len(rtifs) == 1

assert rtifs[0].dag_id == "dag"
Expand Down
Loading