issue-59385: Removing unneeded call the SnowflakeSqlApiHook
#59470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
2 tasks
tirkarthi
reviewed
Dec 15, 2025
providers/snowflake/src/airflow/providers/snowflake/triggers/snowflake_trigger.py
Show resolved
Hide resolved
Collaborator
Author
|
@rawwar, do you mind taking a peek at this one? Thanks! |
potiuk
approved these changes
Dec 16, 2025
FoxHelms
pushed a commit
to FoxHelms/airflow
that referenced
this pull request
Dec 17, 2025
…he#59470) * issue-59385: Removing unneeded call the SnowflakeSqlApiHook * issue-59385: Updating Hook instantiating in proper place
Lohith625
pushed a commit
to Lohith625/airflow
that referenced
this pull request
Dec 19, 2025
…he#59470) * issue-59385: Removing unneeded call the SnowflakeSqlApiHook * issue-59385: Updating Hook instantiating in proper place
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@manipatnam noted that each time the Trigger ran for the
SnowflakeSqlApiOperator, a connection was being made. This issue was tracked down to theSnowflakeSqlApiTrigger, where an unnecessary call was being made toSnowflakeSqlApiHookeach time the trigger ran.This PR removes that call.
Testing
To test the changes made in this PR, please run the command shown below. This will run all tests for the Snowflake provider.
breeze testing providers-tests --test-type "Providers[snowflake]"closes: #59385