Skip to content

issue-59385: Removing unneeded call the SnowflakeSqlApiHook #59470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 4 commits into from
Dec 16, 2025
Merged

issue-59385: Removing unneeded call the SnowflakeSqlApiHook #59470

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4060131
issue-59385: Removing unneeded call the SnowflakeSqlApiHook
jroachgolf84 Dec 15, 2025
ba1eeca
issue-59385: Updating Hook instantiating in proper place
jroachgolf84 Dec 15, 2025
5aaf7ef
Merge branch 'main' into issue-59385
jroachgolf84 Dec 15, 2025
a6cc15a
Merge branch 'main' into issue-59385
jroachgolf84 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions providers/snowflake/src/airflow/providers/snowflake/triggers/snowflake_trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,16 @@ def serialize(self) -> tuple[str, dict[str, Any]]:

async def run(self) -> AsyncIterator[TriggerEvent]:
"""Wait for the query the snowflake query to complete."""
SnowflakeSqlApiHook(
hook = SnowflakeSqlApiHook(
self.snowflake_conn_id,
self.token_life_time,
self.token_renewal_delta,
)

try:
for query_id in self.query_ids:
while True:
statement_status = await self.get_query_status(query_id)
statement_status = await self.get_query_status(query_id, hook)
if statement_status["status"] not in ["running"]:
break
await asyncio.sleep(self.poll_interval)
Expand All @@ -92,13 +93,17 @@ async def run(self) -> AsyncIterator[TriggerEvent]:
except Exception as e:
yield TriggerEvent({"status": "error", "message": str(e)})

async def get_query_status(self, query_id: str) -> dict[str, Any]:
async def get_query_status(
self, query_id: str, hook: SnowflakeSqlApiHook | None = None
) -> dict[str, Any]:
"""Return True if the SQL query is still running otherwise return False."""
hook = SnowflakeSqlApiHook(
self.snowflake_conn_id,
self.token_life_time,
self.token_renewal_delta,
)
if not hook:
hook = SnowflakeSqlApiHook(
self.snowflake_conn_id,
self.token_life_time,
self.token_renewal_delta,
)

return await hook.get_sql_api_query_status_async(query_id)

def _set_context(self, context):
Expand Down