feat: add only_new to dag clear function #59764
Open
+207
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
feat/dag-clear-only-new-tasks
branch
from
505c4a3 to
c822b20
Compare
potiuk
reviewed
Jan 7, 2026
| from airflow.models.taskinstance import clear_task_instances | ||
|
|
||
| state: list[TaskInstanceState] = [] | ||
|
|
Member
There was a problem hiding this comment.
LGTM, but Since it indeed touches core airflow definitions, I would love if other maintainers more familiar with it will take a look - I am afraid this might not be optimal way of doing it and possibly it can be done simpler.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review and pointing this out. I have a similar feeling, but lack the context to come up with said simpler solution.
Would also appreciate any more opinions from others!
Contributor
Author
There was a problem hiding this comment.
@ashb @bolkedebruin - could either of you have a second glance at this PR?
Contributor
Author
|
@potiuk do you think we can go ahead with this? Or would you like me to chase after some more reviews? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The ability to clear newly introduced tasks in an already existing DAG run seems not to have been added to Airflow 3 yet.
The button in the UI is disabled at all times.
Implementation
In this PR I try to start with the basic requirement, which is to add functionality to the
dag.clear()function that ensures only newly added tasks are cleared.Questions to Reviewer
run_on_latest_version, but I am unsure of its purpose. I've seen it's experimental and I wonder if it is at all involved with the issue attached to this PR.Issue
See below the related issues.
related: #57051
related: #56250
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.