Fix SDK to read default_email_on_failure and default_email_on_retry from config#59912
Merged
potiuk merged 3 commits intoapache:mainfrom Dec 31, 2025
Merged
Conversation
justinpakzad
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
potiuk
reviewed
Dec 29, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM, but I wonder if this is really intended. It looks like it should be. Also it would be great to get some tests covering it ?
Contributor
Author
So there are already two tests in the |
amoghrajesh
reviewed
Dec 30, 2025
potiuk
approved these changes
Dec 31, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
…rom config (apache#59912) * Added variable to fetch email on retry/failure values from conf * prek formatting * prek formatting
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
…rom config (apache#59912) * Added variable to fetch email on retry/failure values from conf * prek formatting * prek formatting
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
…rom config (apache#59912) * Added variable to fetch email on retry/failure values from conf * prek formatting * prek formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #59380
The SDK is not reading the config values for default_email_on_failure/default_email_on_retry and they are hardcoded as True. I updated the default values to fetch from the config.
If the config is intentionally no longer used (due to deprecation of these params) then I can mark it as deprecated in the configuration reference and config template, with a note directing users to set email_on_failure explicitly in default_args instead.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.