Skip to content

Fix SDK to read default_email_on_failure and default_email_on_retry from config #59912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 3 commits into from
Dec 31, 2025
Merged

Fix SDK to read default_email_on_failure and default_email_on_retry from config #59912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
882e77e
Added variable to fetch email on retry/failure values from conf
justinpakzad Dec 29, 2025
0ddfd5b
prek formatting
justinpakzad Dec 29, 2025
275496c
prek formatting
justinpakzad Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions task-sdk/src/airflow/sdk/bases/operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
from airflow.sdk import TriggerRule, timezone
from airflow.sdk._shared.secrets_masker import redact
from airflow.sdk.definitions._internal.abstractoperator import (
DEFAULT_EMAIL_ON_FAILURE,
DEFAULT_EMAIL_ON_RETRY,
DEFAULT_IGNORE_FIRST_DEPENDS_ON_PAST,
DEFAULT_OWNER,
DEFAULT_POOL_NAME,
Expand Down Expand Up @@ -219,8 +221,8 @@ def partial(**kwargs):
OPERATOR_DEFAULTS: dict[str, Any] = {
"allow_nested_operators": True,
"depends_on_past": False,
"email_on_failure": True,
"email_on_retry": True,
"email_on_failure": DEFAULT_EMAIL_ON_FAILURE,
"email_on_retry": DEFAULT_EMAIL_ON_RETRY,
"execution_timeout": DEFAULT_TASK_EXECUTION_TIMEOUT,
# "executor": DEFAULT_EXECUTOR,
"executor_config": {},
Expand Down Expand Up @@ -826,8 +828,8 @@ def say_hello_world(**context):
task_id: str
owner: str = DEFAULT_OWNER
email: str | Sequence[str] | None = None
email_on_retry: bool = True
email_on_failure: bool = True
email_on_retry: bool = DEFAULT_EMAIL_ON_RETRY
email_on_failure: bool = DEFAULT_EMAIL_ON_FAILURE
retries: int | None = DEFAULT_RETRIES
retry_delay: timedelta = DEFAULT_RETRY_DELAY
retry_exponential_backoff: float = 0
Expand Down Expand Up @@ -984,8 +986,8 @@ def __init__(
task_id: str,
owner: str = DEFAULT_OWNER,
email: str | Sequence[str] | None = None,
email_on_retry: bool = True,
email_on_failure: bool = True,
email_on_retry: bool = DEFAULT_EMAIL_ON_RETRY,
email_on_failure: bool = DEFAULT_EMAIL_ON_FAILURE,
retries: int | None = DEFAULT_RETRIES,
retry_delay: timedelta | float = DEFAULT_RETRY_DELAY,
retry_exponential_backoff: float = 0,
Expand Down
3 changes: 2 additions & 1 deletion task-sdk/src/airflow/sdk/definitions/_internal/abstractoperator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@
DEFAULT_TASK_EXECUTION_TIMEOUT: datetime.timedelta | None = conf.gettimedelta(
"core", "default_task_execution_timeout"
)

DEFAULT_EMAIL_ON_FAILURE: bool = conf.getboolean("email", "default_email_on_failure", fallback=True)
DEFAULT_EMAIL_ON_RETRY: bool = conf.getboolean("email", "default_email_on_retry", fallback=True)
log = logging.getLogger(__name__)


Expand Down