Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions providers/fab/src/airflow/providers/fab/www/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
from airflow.configuration import conf
from airflow.exceptions import AirflowConfigException
from airflow.logging_config import configure_logging
from airflow.providers.fab.www.extensions.init_appbuilder import AirflowAppBuilder
from airflow.providers.fab.www.extensions.init_appbuilder import init_appbuilder
from airflow.providers.fab.www.extensions.init_jinja_globals import init_jinja_globals
from airflow.providers.fab.www.extensions.init_manifest_files import configure_manifest_files
from airflow.providers.fab.www.extensions.init_security import init_api_auth
Expand Down Expand Up @@ -93,12 +93,7 @@ def create_app(enable_plugins: bool):
init_api_auth(flask_app)

with flask_app.app_context():
AirflowAppBuilder(
app=flask_app,
session=db.session(),
base_template="airflow/main.html",
enable_plugins=enable_plugins,
)
init_appbuilder(flask_app, enable_plugins=enable_plugins)
init_error_handlers(flask_app)
# In two scenarios a Flask application can be created:
# - To support Airflow 2 plugins relying on Flask (``enable_plugins`` is True)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
from flask_appbuilder import BaseView
from flask_appbuilder.security.manager import BaseSecurityManager
from sqlalchemy.orm import Session
from sqlalchemy.orm.scoping import scoped_session


# This product contains a modified portion of 'Flask App Builder' developed by Daniel Vaz Gaspar.
Expand Down Expand Up @@ -102,7 +103,7 @@ class AirflowAppBuilder:
def __init__(
self,
app=None,
session: Session | None = None,
session: scoped_session | None = None,
menu=None,
indexview=None,
base_template="airflow/main.html",
Expand Down Expand Up @@ -597,7 +598,7 @@ def init_appbuilder(app: Flask, enable_plugins: bool) -> AirflowAppBuilder:
raise RuntimeError("Session not configured. Call configure_orm() first.")
return AirflowAppBuilder(
app=app,
session=settings.Session(),
session=settings.Session,
base_template="airflow/main.html",
enable_plugins=enable_plugins,
)

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion providers/fab/www-hash.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
b8ebef1806aed0a26ed8fd468040a51eaec700520bd41dbbdbf8136a4663eb6e
bdf94b6efdefff18f884d1d1c2c37c5df9ef52730797f82324651570e4d9e948