Skip to content

Conversation

@trina242
Copy link
Contributor

related: #59349

This PR is yet another attempt to get rid of sqlalchemy.exc.PendingRollbackError in FAB provider caused by duplicated sessions. I believe previously applied fixes #57815 and #58196 were a way to go, although an important change - using scoped_session instead of Session - was overridden later by #58644.

I decided to use scoped_session directly in AirflowAppBuilder as it's safe to use both inside and outside the application due to implicit method access and it simplifies otherwise messy type annotations.

First contribution, please be nice 😉

@trina242 trina242 requested a review from vincbeck as a code owner December 30, 2025 23:40
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 30, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@vincbeck vincbeck merged commit 3ed08df into apache:main Jan 5, 2026
85 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 5, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants