Make FAB AirflowAppBuilder use scoped_session #59953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #59349
This PR is yet another attempt to get rid of
sqlalchemy.exc.PendingRollbackErrorin FAB provider caused by duplicated sessions. I believe previously applied fixes #57815 and #58196 were a way to go, although an important change - usingscoped_sessioninstead ofSession- was overridden later by #58644.I decided to use
scoped_sessiondirectly inAirflowAppBuilderas it's safe to use both inside and outside the application due to implicit method access and it simplifies otherwise messy type annotations.First contribution, please be nice 😉