Skip to content

Comments

Fix Edge plugin NavTabs navigation for React Router v7#61026

Closed
neverlish wants to merge 1 commit intoapache:mainfrom
neverlish:bugfix-provider-edge3-navlink-relativepath
Closed

Fix Edge plugin NavTabs navigation for React Router v7#61026
neverlish wants to merge 1 commit intoapache:mainfrom
neverlish:bugfix-provider-edge3-navlink-relativepath

Conversation

@neverlish
Copy link

@neverlish neverlish commented Jan 25, 2026

solves: #61004

related issue

solved

  • before change
tabs-main-before.mov
  • after change
tabs-main-solved.mov
  • language in video is korean, but code change in this PR is not related to language. it's on my user setting
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 25, 2026

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Jan 25, 2026
@neverlish neverlish force-pushed the bugfix-provider-edge3-navlink-relativepath branch from 8c37bbd to 9bfd38e Compare January 25, 2026 07:54
@jscheffl
Copy link
Contributor

Thanks for the fix! First hand this looks good, the problem is now fixed with the UI on main.

Unfortunately clicking on the link "Jobs" in the plugin in Airflow 3.1.6 UI the path get set to http://localhost:28080/plugin/jobs instead of http://localhost:28080/plugin/edge_executor/jobs - so we need to find a way that it working with both versions.

To make this PR green in CI - unfortunately the assets are still built static, PR to make this better is still pending in #56456) you need to run prek as pre-commit check in your environment, or specifically prek run -a compile-edge-assets to manually compile assets.

@jscheffl jscheffl mentioned this pull request Jan 26, 2026
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Jan 27, 2026

I'll handle the backward compatibility issue in #61078. Closing this one as this is duplicated and #61078 is close to being mergeable, sorry for the inconvenience.

@neverlish
Copy link
Author

@pierrejeambrun thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants