Skip to content

Fix edge3 router#61078

Merged
jscheffl merged 2 commits intoapache:mainfrom
astronomer:fix-edge3-router
Jan 27, 2026
Merged

Fix edge3 router#61078
jscheffl merged 2 commits intoapache:mainfrom
astronomer:fix-edge3-router

Conversation

@pierrejeambrun
Copy link
Member

@pierrejeambrun pierrejeambrun commented Jan 26, 2026

I suspected this was caused by the core react-dom-router upgrade. (#60316) But this was released in 3.1.6, is edge3 having issue with latest release?

This should look better now.

closes: #61004

@boring-cyborg boring-cyborg bot added area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Jan 26, 2026
@jscheffl
Copy link
Contributor

jscheffl commented Jan 26, 2026

Thanks for the PR! I made a regression and similar like PR #61026 it fixes the problem on main. But breaks the UI on 3.1.6

Is it possible to render this conditionally based on the core version? Do we have any mechanisms?

P.S.: Also checked with 3.1.5 and this also behaves like 3.1.6 :-(

@pierrejeambrun
Copy link
Member Author

@jscheffl I added a backward compatibility logic. We could do that. It should behaves the same when core is <= 3.1.6 and do the new navigation when core is > 3.1.6

@vincbeck
Copy link
Contributor

@jscheffl Can you please review? Ideally I'd like to include it in my provider release

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd rather wait for Jens' approval

@jscheffl
Copy link
Contributor

Cool! Just arrived home, need to have dinner with family, then I'll test immediately!

@pierrejeambrun so means in 3.1.7 it will be broken the same way like it is on main if not fixed? Because you check on <=3.1.6 and not on <3.2.0||main

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to test before dinner! Looks good! Thanks for the back-compat!

(Tested on main, 3.1.6, 3.1.5)

NOTE: I also did a test on v3-1-test and there it is TOTALLY broken, needed to F5 to correctly load initially when clicking. Probably some other nit we need to fix before 3.1.7 cut-off. In regards of back-compat detection manually bumped v3-1-test branch to local veryion 3.1.7 before testing.

@jscheffl
Copy link
Contributor

Merging as fix is good for main but most probably we need to change / fix either core or plugin to make ti working for 3.1.7

@jscheffl jscheffl merged commit aad6d49 into apache:main Jan 27, 2026
71 checks passed
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
* Fix edge3 router

* Add backward compatibility support
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
* Fix edge3 router

* Add backward compatibility support
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
* Fix edge3 router

* Add backward compatibility support
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
* Fix edge3 router

* Add backward compatibility support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edge Plugin UI is broken on main / Airflow 3.2

3 participants

Comments