Conversation
|
Thanks for the PR! I made a regression and similar like PR #61026 it fixes the problem on main. But breaks the UI on 3.1.6 Is it possible to render this conditionally based on the core version? Do we have any mechanisms? P.S.: Also checked with 3.1.5 and this also behaves like 3.1.6 :-( |
|
@jscheffl I added a backward compatibility logic. We could do that. It should behaves the same when core is <= 3.1.6 and do the new navigation when core is > 3.1.6 |
95794d4 to
d3ced85
Compare
d3ced85 to
cfe938e
Compare
|
@jscheffl Can you please review? Ideally I'd like to include it in my provider release |
vincbeck
left a comment
There was a problem hiding this comment.
LGTM but I'd rather wait for Jens' approval
|
Cool! Just arrived home, need to have dinner with family, then I'll test immediately! @pierrejeambrun so means in 3.1.7 it will be broken the same way like it is on main if not fixed? Because you check on <=3.1.6 and not on <3.2.0||main |
jscheffl
left a comment
There was a problem hiding this comment.
Was able to test before dinner! Looks good! Thanks for the back-compat!
(Tested on main, 3.1.6, 3.1.5)
NOTE: I also did a test on v3-1-test and there it is TOTALLY broken, needed to F5 to correctly load initially when clicking. Probably some other nit we need to fix before 3.1.7 cut-off. In regards of back-compat detection manually bumped v3-1-test branch to local veryion 3.1.7 before testing.
|
Merging as fix is good for main but most probably we need to change / fix either core or plugin to make ti working for 3.1.7 |
* Fix edge3 router * Add backward compatibility support
* Fix edge3 router * Add backward compatibility support
* Fix edge3 router * Add backward compatibility support
* Fix edge3 router * Add backward compatibility support
I suspected this was caused by the core
react-dom-routerupgrade. (#60316) But this was released in 3.1.6, is edge3 having issue with latest release?This should look better now.
closes: #61004