Skip to content

Conversation

@JiaLiangC
Copy link
Contributor

What changes were proposed in this pull request?

https://issues.apache.org/jira/browse/AMBARI-26009
(Please fill in changes proposed in this fix)

How was this patch tested?

manual test
unit test
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@JiaLiangC
Copy link
Contributor Author

@arshadmohammad
Hello, I have rebased on the latest master branch. Could you please review it again?

@JiaLiangC
Copy link
Contributor Author

@vanshuhassija Could you help review this pr?
This CI error is not related to this PR.
it's an issue with the trunk branch.

@arshadmohammad @vanshuhassija @brahmareddybattula
CI failed details : #3751 (comment)

The CI failure is due to the PR (https://github.com/apache/ambari/pull/3760)that was merged earlier. Can we first revert it to solve all the CI failure issues, and then merge it again after the PR-related CI failure issue is resolved? Otherwise, all PRs are affected.

@Danori
Copy link
Contributor

Danori commented Apr 25, 2024

@JiaLiangC I'm planning on opening a JIRA soon for Rocky9 support, and I don't want my changes to conflict with yours here since there will be a bit of overlap (e.g. the os_check.py & the metainfo.xml changes). Any plans on merging these changes?

@JiaLiangC
Copy link
Contributor Author

@JiaLiangC I'm planning on opening a JIRA soon for Rocky9 support, and I don't want my changes to conflict with yours here since there will be a bit of overlap (e.g. the os_check.py & the metainfo.xml changes). Any plans on merging these changes?

Thank you for your feedback. I will request a review from the community members again.
@vanshuhassija Could you help review this pr?

@JiaLiangC
Copy link
Contributor Author

@virajjasani @arshadmohammad @brahmareddybattula could u help review this pr?

@virajjasani
Copy link
Contributor

Overall looks good. @arshadmohammad any more review from your side?

@arshadmohammad
Copy link
Contributor

Overall looks good. @arshadmohammad any more review from your side?
sure, I will review it.

@arshadmohammad
Copy link
Contributor

arshadmohammad commented May 15, 2024

Earlier I was able to build ambari on rocky linux 8, but now the build is failing. May be the impact is there becuase of other changes.

[INFO] Running 'yarn install --ignore-engines --pure-lockfile' in /home/code/forked/ambari/ambari-web
[INFO] yarn install v0.23.2
[ERROR] warning Ambari@2.4.0: No license field
[INFO] [1/4] Resolving packages...
[ERROR] error An unexpected error occurred: "https://registry.yarnpkg.com/phantomjs: connect ENETUNREACH 104.16.3.35:443".
[INFO] info If you think this is a bug, please open a bug report with the information provided in "/home/code/forked/ambari/ambari-web/yarn-error.log".
[INFO] info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Ambari Main 3.0.0.0-SNAPSHOT:
[INFO]
[INFO] Ambari Main ........................................ SUCCESS [ 2.738 s]
[INFO] Apache Ambari Project POM .......................... SUCCESS [ 0.127 s]
[INFO] Ambari Web ......................................... FAILURE [ 3.139 s]
[INFO] Ambari Views ....................................... SKIPPED
[INFO] Ambari Admin View .................................. SKIPPED
[INFO] ambari-utility ..................................... SKIPPED
[INFO] Ambari Server SPI .................................. SKIPPED
[INFO] Ambari Service Advisor ............................. SKIPPED
[INFO] Ambari Server ...................................... SKIPPED
[INFO] Ambari Functional Tests ............................ SKIPPED
[INFO] Ambari Agent ....................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:20 min
[INFO] Finished at: 2024-05-15T09:47:30+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.4:yarn (yarn install) on project ambari-web: Failed to run task: 'yarn install --ignore-engines --pure-lockfile' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :ambari-web
[root@rocky1 ambari]# mvn clean install rpm:rpm -DskipTests

I will check more what is cuasing this problem.

@JiaLiangC
Copy link
Contributor Author

JiaLiangC commented May 16, 2024

@arshadmohammad
I tested the compilation on Rocky8, and it was successful. The test commands and results are shown in the figure belowimage

@JiaLiangC
Copy link
Contributor Author

@arshadmohammad Your error appears to be related to PhantomJS. In my branch, I have already included the previous PR that removed PhantomJS. Removing PhantomJS can simplify the compilation process significantly. However, the previous PR for PhantomJS caused CI/CD to fail, so it was reverted. Even after reverting, CI/CD still did not recover. You can merge the changes that remove PhantomJS dependencies, and the compilation should succeed

Copy link
Contributor

@arshadmohammad arshadmohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@JiaLiangC
Copy link
Contributor Author

@virajjasani Could you help check and merge this pr?

@virajjasani
Copy link
Contributor

+1, btw we recently enabled RHEL9 support as well.

@virajjasani virajjasani merged commit 9df863b into apache:trunk Jun 13, 2024
@JiaLiangC
Copy link
Contributor Author

+1, btw we recently enabled RHEL9 support as well.

It looks like Danori is already working on enabling RHEL9 support.

@JiaLiangC JiaLiangC deleted the AMBARI-26009 branch June 21, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants