-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AMBARI-26009: Add Rocky8 operating system support #3758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4ad9593 to
84bbdf7
Compare
|
@arshadmohammad |
|
@vanshuhassija Could you help review this pr? @arshadmohammad @vanshuhassija @brahmareddybattula The CI failure is due to the PR (https://github.com/apache/ambari/pull/3760)that was merged earlier. Can we first revert it to solve all the CI failure issues, and then merge it again after the PR-related CI failure issue is resolved? Otherwise, all PRs are affected. |
|
@JiaLiangC I'm planning on opening a JIRA soon for Rocky9 support, and I don't want my changes to conflict with yours here since there will be a bit of overlap (e.g. the os_check.py & the metainfo.xml changes). Any plans on merging these changes? |
Thank you for your feedback. I will request a review from the community members again. |
|
@virajjasani @arshadmohammad @brahmareddybattula could u help review this pr? |
|
Overall looks good. @arshadmohammad any more review from your side? |
|
|
Earlier I was able to build ambari on rocky linux 8, but now the build is failing. May be the impact is there becuase of other changes. [INFO] Running 'yarn install --ignore-engines --pure-lockfile' in /home/code/forked/ambari/ambari-web I will check more what is cuasing this problem. |
|
@arshadmohammad |
|
@arshadmohammad Your error appears to be related to PhantomJS. In my branch, I have already included the previous PR that removed PhantomJS. Removing PhantomJS can simplify the compilation process significantly. However, the previous PR for PhantomJS caused CI/CD to fail, so it was reverted. Even after reverting, CI/CD still did not recover. You can merge the changes that remove PhantomJS dependencies, and the compilation should succeed |
arshadmohammad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
|
@virajjasani Could you help check and merge this pr? |
|
+1, btw we recently enabled RHEL9 support as well. |
It looks like Danori is already working on enabling RHEL9 support. |

What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/AMBARI-26009
(Please fill in changes proposed in this fix)
How was this patch tested?
manual test
unit test
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.