-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AMBARI-26000: Make Ambari supports Python3 environment #3751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: jialiang <2510095164@qq.com>
|
Python3 rely on Phenomenon: Please install distro module by using command: |
2.fix sudo encoding error 3.remove redunant get_encoded_string
|
@brahmareddybattula @virajjasani |
|
Sorry I couldn't take a look. @arshadmohammad you think you can take a look at CI pipeline for python 3 installation? |
no idea how to access the CI Vms, but let me run distro installation as part of the test execution script itself. lets see whether it works |
thanks man |
|
installing distro package, as part of the test execution script, does not work. https://ci-hadoop.apache.org/blue/organizations/jenkins/Ambari%2FAmbari-PreCommit-GitHub-PR/detail/PR-3754/1/pipeline |
|
@arshadmohammad it seems your change in jenkinsfile not working fine ,maybe you can try this |
Thank you very much for your assistance! |
|
@arshadmohammad Could you help trigger the CI/CD process of this PR again? |
|
|
@virajjasani @arshadmohammad @brahmareddybattula I've already reviewed this PR and tested multiple times. Once this PR is merged, it will greatly simplify support for multiple operating systems and different architectures. |
|
@guyuqi please help to review the code, thanks. |
| print server_hostname() | ||
| print(hostname()) | ||
| print(public_hostname()) | ||
| print(server_hostname()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for finding this, I will fix it later.
|
There are some e.g. yum_manager.py def rpm_check_package_available(self, name):
import rpm # this is faster then calling 'rpm'-binary externally. |
| from urllib.error import HTTPError | ||
|
|
||
| from tempfile import gettempdir | ||
| from alerts.base_alert import BaseAlert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alerts.base_alert => ambari_agent.alerts.base_alert
Maybe it should be also changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both these two way are work.
Yes, |
|
I will review this PR. |
|
I was trying to build this PR(also applied #3758 changes) on rocky linux 8.8 but build failed with following error |
Things to note when compiling on Rocky8: |
f06a089 to
25f64c2
Compare
25f64c2 to
3d7e900
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like it should be 'w' rather than 'wb' in line 278,it's work when I using ambari-agent setup x, but if 'wb', it will clean the .ini file and raise error like: "a bytes-like object is required, not 'str'"
|
@wenwj0 @JiaLiangC any idea why CI is failing? |
The log shows that there is an error in The only error I found in this part is |
|
@arshadmohammad The error can be reproduced in the trunk branch code due to PR #3760. Cause: How to reproduce:
As shown above, the error message is the same as in CI, confirming the reproduction of the issue! How to solve:
export CHROME_BIN=/usr/bin/chromium-browser Continue execution:
How to solve: vim /usr/bin/chromium-browser Add Then the compilation succeeds. |
|
Thanks @JiaLiangC for detailed information on CI. We will address CI issue separate PR. |
|
As discussed in mailing thread https://lists.apache.org/thread/htsfrt0zh89ql9covz721j696tskwqx3, I am going to merge this PR. |
arshadmohammad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
|
Thank @arshadmohammad very much for reviewing and merging the code, and also thank @Jetiaime and @eubnara for reviewing the code. |
as mentioned above, the CI failed because your PR #3760 |
|
@arshadmohammad |
|
|
Hi! |
|
@Jati-Jostar @minixar Apologies for the lack of community manpower and missing relevant documentation. The 3.0 version is set to be released this month, which will include detailed compilation, deployment, and installation documentation, supporting both rocky8 and rocky9. |
|
Thank @JiaLiangC for sharing the news about the release of the 3.0 version. |
|
ohh ok,thanks for the information sir
|
|
@Jati-Jostar @minixar The issue with the RPM packaging failure was caused by the system's handling of the shebang, and it has been resolved. The relevant fixes and compilation commands are in this PR: #3952 |
|
hi @JiaLiangC Hello,
|
hi @arshadmohammad @JiaLiangC
|
|
Hello, I was able to build Apache Ambari successfully. Now, I want to install BigTop 3.3 services using Ambari. I have two questions for you: 1 - Do I need to build BigTop from scratch so that its packages are like zookeeper_3_3_3 instead of just zookeeper? Because I use the -PpkgSuffix option during the build process. Can Ambari use the packages that were built by you and published on the Apache website directly, or do I need to build them myself? 2 - And my last question is that bigtop-select uses Python 2, but the version of Ambari I have uses Python 3, and most of the time this causes problems. What is your solution for installing BigTop 3.3 with Ambari that is running on Python 3? |
|
Hi @simonj217 |
















What changes were proposed in this pull request?
Ambari-support-python3.mdin AMBARI-26000How was this patch tested?
Please review Ambari Contributing Guide before opening a pull request.