-
Notifications
You must be signed in to change notification settings - Fork 1.7k
AMBARI-26100: Fix all python script file to python3 #3799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @JiaLiangC |
|
@virajjasani This is quite a substantial PR aimed at unifying the Python interpreter headers. Do you have any thoughts or insights on this? |
|
Indeed this is huge PR. Thanks for working on this @zRains. Curious what would be the testing approach here? We want to make sure that we are not breaking anything. |
|
@virajjasani The added interpreter declarations may not be used and generally have little side effect. Since Python 3 is already supported in #3751 we can safely replace the declarations. All changes have passed the tests. |
|
Sounds good. Let me take a look today. @JiaLiangC you can also take a look in the meantime. |
|
|
hi, turned on ranger and kerberos and found that some python scripts reported errors and failed because python3 was not supported yet. I found that some scripts only declare python3 at the beginning, but the syntax and other errors in them seem to have not been corrected. 136 :admin_password = unicode(admin_password) |
|
@quanzhouwang thank you for reporting these errors. Are you interested in creating separate Jira and also PR to fix them? |
|
@virajjasani @quanzhouwang Hello, the related PR for enabling Kerberos has been submitted but not yet merged. You can refer to this PR to fix the issue you are encountering: https://github.com/apache/ambari/pull/3793/files#diff-aed3ca5cc011c2ddb3a5950cd8b6cf4ff3486275ed6d1d7a9af1a39beb9f914cL47 |
|
@JiaLiangC @virajjasani thank , let’s try repackaging and installing to see if this problem exists, |
What changes were proposed in this pull request?
Modify the interpreter for all Python files to python3.
How was this patch tested?
N/A