AMBARI-25985 Remove phantomjs headless browser #3760
Conversation
vanshuhassija
force-pushed
the
AMBARI-25985-remove-phantomjs-as-headless-browser
branch
2 times, most recently
from
951b5c9 to
82f87cf
Compare
vanshuhassija
changed the title
vanshuhassija
force-pushed
the
AMBARI-25985-remove-phantomjs-as-headless-browser
branch
from
82f87cf to
ecb74f9
Compare
What changes were proposed in this pull request? PhantomJS is a headless web browser scriptable with JavaScript. The package is no longer maintained and does not even support ES6 features of Javascript. Chrome launched ChromeHeadless which works very similar to PhantomJs. The fix will require Karma to use ChromeHeadless as the web browser instead of PhantomJs How was this patch tested? Ran test cases for ambari-web and it gives the desired reports. Please review Ambari Contributing Guide before opening a pull request. Karma Amabri web admin chrome headless Remve phantom js package
vanshuhassija
force-pushed
the
AMBARI-25985-remove-phantomjs-as-headless-browser
branch
from
e78706b to
f024a78
Compare
This reverts commit 48de4b9.
|
@arshadmohammad I remember you previously handled a PR related to PhantomJS. Have you already installed PhantomJS in the Ambari Jenkins environment? Can you explain the PhantomJS environment configuration work you did before? The frontend team needs to move forward, and we need to install PhantomJS in the Jenkins environment." |
|
This PR had removed the PhantomJS. No CI change was done for this PR. |
|
@arshadmohammad I apologize for the slip of the tongue earlier, I meant Chromium browser, not PhantomJS. |
|
No CI change was done for Chromium browser. |
|
@arshadmohammad @JiaLiangC No CI changes were done for ChromeHeadless. The CI ran as expected without defining custom ChromeHeadless sandbox behaviour. Simply specifying ChromeHeadless as the browser worked for me. |
|
@arshadmohammad @vanshuhassija Thank you for the information you provided. I wrote a Jenkins script to test whether the Jenkins environment has Chromium, and the conclusion is that it doesn't. You can find the script at #3810. I have already submitted an issue to the ASF infra team, and we're now waiting for them to process it and install Chromium in the Jenkins environment. |
3 participants
PhantomJS is a headless web browser scriptable with JavaScript. The package is no longer maintained and does not even support ES6 features of Javascript. Chrome launched ChromeHeadless which works very similar to PhantomJs. The fix will require Karma to use ChromeHeadless as the web browser instead of PhantomJs
How was this patch tested?
Ran test cases for ambari-web and it gives the desired reports.
Please review Ambari Contributing Guide before opening a pull request.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)
Please review Ambari Contributing Guide before opening a pull request.