[ARCTIC-1016] Moving files will fail if the target parent directory doesn't exist in HDFS #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 2, 2023 11:43
github-actions
bot
added
module:ams-server
|
cc @zhoujinsong |
wangtaohz
reviewed
Feb 7, 2023
There was a problem hiding this comment.
@shendanfengg Thanks for your work.
I left some comment, please take a look.
hive/src/main/java/com/netease/arctic/hive/CachedHiveClientPool.java
Outdated
Show resolved
Hide resolved
wangtaohz
approved these changes
Feb 8, 2023
zhoujinsong
reviewed
Feb 8, 2023
core/src/main/java/com/netease/arctic/io/ArcticHadoopFileIO.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/ArcticHadoopFileIO.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/netease/arctic/io/ArcticHadoopFileIO.java
Outdated
Show resolved
Hide resolved
Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
wangtaohz
added a commit
that referenced
this pull request
Feb 8, 2023
…oesn't exist in HDFS (#1046) * fix 1016 * refactoring functions and removing useless code Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com> Co-authored-by: wangtaohz <103108928+wangtaohz@users.noreply.github.com> Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com> (cherry picked from commit ab97314) Signed-off-by: wangtao <wangtao3@corp.netease.com>
|
I have cherry-picked it to 0.3.x |
wangtaohz
added a commit
to wangtaohz/amoro
that referenced
this pull request
Mar 15, 2023
…ed files (apache#1169) cherry pick [ARCTIC-1016] Moving files will fail if the target parent directory doesn't exist in HDFS apache#1046
3 tasks
zhoujinsong
pushed a commit
that referenced
this pull request
Mar 20, 2023
* cherry pick [ARCTIC-1167][core] Introduce `Trash` for restoring deleted files (#1169) cherry pick [ARCTIC-1016] Moving files will fail if the target parent directory doesn't exist in HDFS #1046 * cherry pick [ARCTIC-1167][core][hive] fix Trash for restoring deleted files (#1223) * add getSyncFileInfoCachePool back for ThreadPool * [ARCTIC-1167][core][hive] fix Unkeyed Table location and metadata file pattern for `Trash` (#1229)
This was referenced Apr 21, 2023
zhoujinsong
added a commit
that referenced
this pull request
May 31, 2023
…oesn't exist in HDFS (#1046) * fix 1016 * refactoring functions and removing useless code Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com> Co-authored-by: wangtaohz <103108928+wangtaohz@users.noreply.github.com> Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…oesn't exist in HDFS (apache#1046) * fix 1016 * refactoring functions and removing useless code Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com> Co-authored-by: wangtaohz <103108928+wangtaohz@users.noreply.github.com> Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Fix #1016
Brief change log
*Exception thrown when FileSystem returns false.
*If the new path does not exist during Support Hive Commit, and then create it.
*Fix some simple grammar errors.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation