[ARCTIC-1167][core][hive] fix Trash for restoring deleted files #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…part of partitions at a time (apache#1220) * support partition ordered by PartitionWeight for OptimizePlan * if not all partitions are optimized, current change snapshot id should set to -1
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1223 +/- ##
=============================================
- Coverage 52.69% 28.90% -23.80%
- Complexity 523 5158 +4635
=============================================
Files 43 663 +620
Lines 3704 69592 +65888
Branches 354 8021 +7667
=============================================
+ Hits 1952 20114 +18162
- Misses 1622 47542 +45920
- Partials 130 1936 +1806
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 617 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
wangtaohz
added a commit
to wangtaohz/amoro
that referenced
this pull request
Mar 15, 2023
3 tasks
zhoujinsong
pushed a commit
that referenced
this pull request
Mar 20, 2023
* cherry pick [ARCTIC-1167][core] Introduce `Trash` for restoring deleted files (#1169) cherry pick [ARCTIC-1016] Moving files will fail if the target parent directory doesn't exist in HDFS #1046 * cherry pick [ARCTIC-1167][core][hive] fix Trash for restoring deleted files (#1223) * add getSyncFileInfoCachePool back for ThreadPool * [ARCTIC-1167][core][hive] fix Unkeyed Table location and metadata file pattern for `Trash` (#1229)
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
* fix ArcticHadoopFileIO cast error * overwrite file in trash when move * [ARCTIC-1213] Optimizing of Mixed Format Table supports optimizing a part of partitions at a time (#1220) * support partition ordered by PartitionWeight for OptimizePlan * if not all partitions are optimized, current change snapshot id should set to -1 * fix checkstyle * TableTrashManager should extends Serializable
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…he#1223) * fix ArcticHadoopFileIO cast error * overwrite file in trash when move * [ARCTIC-1213] Optimizing of Mixed Format Table supports optimizing a part of partitions at a time (apache#1220) * support partition ordered by PartitionWeight for OptimizePlan * if not all partitions are optimized, current change snapshot id should set to -1 * fix checkstyle * TableTrashManager should extends Serializable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #1167, add some hot-fix
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation