Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCTIC-1091] Browser tab does not display Arctic's icon #1092

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

shendanfengg
Copy link
Contributor

Why are the changes needed?

fix #1091

Brief change log

  • *Manually load the static resource favicon.ico
  • *Fix some grammar errors

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduces a new feature? (no)

@shendanfengg shendanfengg requested a review from Aireed February 9, 2023 09:32
@github-actions github-actions bot added module:ams-server Ams server module module:ams-dashboard Ams dashboard module labels Feb 9, 2023
Copy link
Contributor

@Aireed Aireed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aireed Aireed merged commit 2630fd9 into apache:master Feb 14, 2023
wangtaohz added a commit that referenced this pull request Feb 15, 2023
* [ARCTIC-1062][AMS]Terminal support config spark properties in the local model (#1094)

* terminal support config spark properties in the local model

---------

Co-authored-by: jinsilei <jinsilei@corp.netease.com>

* [AMS][Improvement]: Support set login user and login password in config yaml file (#1086)

* Support set login user and login password in config yaml file

* [ARCTIC-1091] Browser tab does not display Arctic's icon (#1092)

fix-1091

Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com>

* [ARCTIC-1090][AMS]:Terminal support add hadoop conf when use native iceberg (#1099)

* terminal supoort hadoop conf

---------

Co-authored-by: jinsilei <jinsilei@corp.netease.com>

* [ARCTIC-1093] Self-Optimizing scan files from metadata instead of from file info cache (#1100)

* fix-1093 optimize use TableScan

* modify OptimizeIntegrationTest for TestHiveSupport Table

* 1.remove checking any tasks running during the plan
2.remove checking table changed during the plan and check it before scan files
3.AbstractIcebergOptimizePlan use the correct currentSnapshot
4.import OptimizePlanResult to to encapsulate the plan result

* [hotfix] Lower the log level in ShuffleSplitAssigner (#1106)

* [ARCTIC-1095][AMS] Add the sequence number for the native iceberg table when the major optimizing commit (#1101)

* fix #1095
Adding the sequence number in the plan when the major commit for the native iceberg table


---------

Co-authored-by: luting <dylzlt93299@gmail.com>

* [ARCTIC-924][Hive] When AMS runs for a period of time and then cannot connect to HMS (#1054)

---------

Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com>

---------

Co-authored-by: PlanetWalker <52364847+hellojinsilei@users.noreply.github.com>
Co-authored-by: jinsilei <jinsilei@corp.netease.com>
Co-authored-by: wangzeyu <hameizi369@gmail.com>
Co-authored-by: shendanfengg <109209550+shendanfengg@users.noreply.github.com>
Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com>
Co-authored-by: Xianxun Ye <yxx_cmhd@163.com>
Co-authored-by: luting <1004611953@qq.com>
Co-authored-by: luting <dylzlt93299@gmail.com>
zhoujinsong pushed a commit that referenced this pull request May 31, 2023
fix-1091

Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com>
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
fix-1091

Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Browser tab does not display Arctic's icon
2 participants