[ARCTIC-1093] Self-Optimizing scan files from metadata instead of from file info cache #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:ams-server
zhoujinsong
reviewed
Feb 13, 2023
ams/ams-server/src/main/java/com/netease/arctic/ams/server/model/FileTree.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/com/netease/arctic/ams/server/optimize/AbstractArcticOptimizePlan.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/com/netease/arctic/ams/server/optimize/AbstractArcticOptimizePlan.java
Outdated
Show resolved
Hide resolved
...server/src/main/java/com/netease/arctic/ams/server/optimize/AbstractIcebergOptimizePlan.java
Outdated
Show resolved
Hide resolved
ams/ams-server/src/main/java/com/netease/arctic/ams/server/optimize/AbstractOptimizePlan.java
Outdated
Show resolved
Hide resolved
|
@wangtaohz Do not forget to give the PR an appropriate title. |
wangtaohz
changed the title
It's my negligence, I add it. |
2.remove checking table changed during the plan and check it before scan files 3.AbstractIcebergOptimizePlan use the correct currentSnapshot 4.import OptimizePlanResult to to encapsulate the plan result
zhoujinsong
reviewed
Feb 14, 2023
...-server/src/main/java/com/netease/arctic/ams/server/optimize/AbstractArcticOptimizePlan.java
Outdated
Show resolved
Hide resolved
zhoujinsong
approved these changes
Feb 14, 2023
wangtaohz
added a commit
that referenced
this pull request
Feb 15, 2023
* [ARCTIC-1062][AMS]Terminal support config spark properties in the local model (#1094) * terminal support config spark properties in the local model --------- Co-authored-by: jinsilei <jinsilei@corp.netease.com> * [AMS][Improvement]: Support set login user and login password in config yaml file (#1086) * Support set login user and login password in config yaml file * [ARCTIC-1091] Browser tab does not display Arctic's icon (#1092) fix-1091 Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com> * [ARCTIC-1090][AMS]:Terminal support add hadoop conf when use native iceberg (#1099) * terminal supoort hadoop conf --------- Co-authored-by: jinsilei <jinsilei@corp.netease.com> * [ARCTIC-1093] Self-Optimizing scan files from metadata instead of from file info cache (#1100) * fix-1093 optimize use TableScan * modify OptimizeIntegrationTest for TestHiveSupport Table * 1.remove checking any tasks running during the plan 2.remove checking table changed during the plan and check it before scan files 3.AbstractIcebergOptimizePlan use the correct currentSnapshot 4.import OptimizePlanResult to to encapsulate the plan result * [hotfix] Lower the log level in ShuffleSplitAssigner (#1106) * [ARCTIC-1095][AMS] Add the sequence number for the native iceberg table when the major optimizing commit (#1101) * fix #1095 Adding the sequence number in the plan when the major commit for the native iceberg table --------- Co-authored-by: luting <dylzlt93299@gmail.com> * [ARCTIC-924][Hive] When AMS runs for a period of time and then cannot connect to HMS (#1054) --------- Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com> --------- Co-authored-by: PlanetWalker <52364847+hellojinsilei@users.noreply.github.com> Co-authored-by: jinsilei <jinsilei@corp.netease.com> Co-authored-by: wangzeyu <hameizi369@gmail.com> Co-authored-by: shendanfengg <109209550+shendanfengg@users.noreply.github.com> Co-authored-by: shendanfeng01 <shendanfeng01@corp.netease.com> Co-authored-by: Xianxun Ye <yxx_cmhd@163.com> Co-authored-by: luting <1004611953@qq.com> Co-authored-by: luting <dylzlt93299@gmail.com>
3 tasks
This was referenced Apr 21, 2023
zhoujinsong
pushed a commit
that referenced
this pull request
May 31, 2023
…m file info cache (#1100) * support modifying log4j2.xml dynamically * fix-1093 optimize use TableScan * remove partitionPosDeleteFiles from AbstractArcticOptimizePlan * refactor MinorOptimizePlan * modify OptimizeIntegrationTest for TestHiveSupport Table * refactor collectSubTree to splitFileTree * 1.remove checking any tasks running during the plan 2.remove checking table changed during the plan and check it before scan files 3.AbstractIcebergOptimizePlan use the correct currentSnapshot 4.import OptimizePlanResult to to encapsulate the plan result * refactor to SplitIfNoFileExists * fix checkstyle * remove useless comment
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
…m file info cache (apache#1100) * support modifying log4j2.xml dynamically * fix-1093 optimize use TableScan * remove partitionPosDeleteFiles from AbstractArcticOptimizePlan * refactor MinorOptimizePlan * modify OptimizeIntegrationTest for TestHiveSupport Table * refactor collectSubTree to splitFileTree * 1.remove checking any tasks running during the plan 2.remove checking table changed during the plan and check it before scan files 3.AbstractIcebergOptimizePlan use the correct currentSnapshot 4.import OptimizePlanResult to to encapsulate the plan result * refactor to SplitIfNoFileExists * fix checkstyle * remove useless comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
fix #1093
Brief change log
TableScanAPITableScanAPI of BaseStoreChangeTableIncrementalScanAPI of ChangeStorepartitionPosDeleteFiles,partitionNeedMajorOptimizeFiles,partitionDeleteFilesaddBaseFilesIntoFileTreetoAbstractArcticOptimizePlanFileTreeand remove useless methodHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation