Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-1943] using TableConfiguration instead of TableProperties for AMS #1944

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

wangtaohz
Copy link
Contributor

Why are the changes needed?

Close #1943 .

Brief change log

  • using TableConfiguration instead of TableProperties for snapshot expiring and orphan files cleaning

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-dashboard Ams dashboard module label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage is 35.00% of modified lines.

Files Changed Coverage
...er/table/executor/OrphanFilesCleaningExecutor.java 0.00%
...rver/table/executor/SnapshotsExpiringExecutor.java 50.00%
...etease/arctic/server/table/TableConfiguration.java 57.14%

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@HuangFru HuangFru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 80239e1 into apache:master Sep 11, 2023
4 of 6 checks passed
@wangtaohz wangtaohz deleted the fix-1943 branch September 11, 2023 06:38
ShawHee pushed a commit to ShawHee/arctic that referenced this pull request Dec 29, 2023
…for AMS (apache#1944)

* using TableConfiguration instead of TableProperties

* fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-dashboard Ams dashboard module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Using the parameters in TableConfiguration instead of from Table properties
3 participants