[Workflow]: Auto build Official Docker Image #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
shidayang
approved these changes
Oct 18, 2023
|
LGTM |
|
@baiyangtx Should add |
zhoujinsong
reviewed
Oct 18, 2023
.github/workflows/docker-images.yml
Outdated
| - "v*" | ||
|
|
||
|
|
||
| workflow_dispatch: |
There was a problem hiding this comment.
What is the on:workflow_dispatch used for?
GOODBOY008
reviewed
Oct 18, 2023
| on: | ||
| push: | ||
| branches: | ||
| - "master" |
There was a problem hiding this comment.
Build docker triggered by master push is too frequently，we should discuss a better trigger event to build latest docker image.
zhoujinsong
reviewed
Oct 18, 2023
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
* test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test docker ci * test quickdemo docker ci * test quickdemo docker ci * test quickdemo docker ci * test quickdemo docker ci * test quickdemo docker ci * test quickdemo docker ci * add concurrency. * add latest label. * add latest label. * add latest label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Auto build official docker image by github workflow actions.
Brief change log
amoro,optimizer-flink,quickdemowill be built automated.How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation