[Hotfix] Fix typo in config.yaml example #2140
Conversation
| # flink-conf.kubernetes.container.image: "arctic163/optimizer-flink1.14" #optimizer image ref | ||
| # flink-conf.kubernetes.service-account="flink" # service account to manager application job. | ||
| # job-uri: "local:///opt/flink/usrlib/OptimizeJob.jar" # optimizer job main jor for application mode | ||
| # flink-conf.kubernetes.container.image: "arctic163/optimizer-flink1.14:latest" #optimizer image ref |
There was a problem hiding this comment.
The official image has change to arctic163/optimizer-flink:0.6.0-flink1.14 and the default job uri has change to local:///opt/flink/usrlib/optimizer-job.jar
There was a problem hiding this comment.
I did not find the corresponding version of the image arctic163/optimizer-flink:0.6.0-flink1.14. Is this the planned version number?
There was a problem hiding this comment.
Yes, because 0.6.0 has not been officially released yet. Or it can be replaced with master-snapshot. After this PR #2136 is merged, the master branch will always automatically build the latest image.
There was a problem hiding this comment.
If use a fixed version(like 0.6.0-flink1.14), each version update needs to be modified synchronously.
Using master-snapshot will bring a version that does not match release and cause an exception.
I recommend setting it to a fixed version(like latest) or using a variable like {version} to represent it.
WDYT?
There was a problem hiding this comment.
That's fine. we have tag the latest release images as latest
github-actions
bot
added
the
type:docs
* [Hotfix] Fix typo in config.yaml example * [Hotfix] Fix job-uri & flink-conf.kubernetes.container.image
Why are the changes needed?
Fix typo in config.yaml example
Brief change log
managing-optimizers.mdHow was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation