[AMORO-1960] Refactor data expiration to TableMaintainer #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2328 +/- ##
============================================
- Coverage 52.96% 52.96% -0.01%
- Complexity 4303 4310 +7
============================================
Files 516 516
Lines 29716 29799 +83
Branches 2896 2901 +5
============================================
+ Hits 15739 15782 +43
- Misses 12699 12738 +39
- Partials 1278 1279 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Conflicts: # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
shidayang
reviewed
Nov 21, 2023
ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/MaintainStrategy.java
Outdated
Show resolved
Hide resolved
ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/MaintainStrategy.java
Outdated
Show resolved
Hide resolved
|
|
|
I understand that the only difference between partition expiration in change+base and Iceberg is the calculation logic for determining which partitions need to expire. Change+base requires consideration of two tables. So, can we calculate them separately and pass the results to change and base using MixedTableMaintainer? |
shidayang
reviewed
Nov 23, 2023
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
type:docs
# Conflicts: # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java # ams/server/src/main/java/com/netease/arctic/server/optimizing/maintainer/TableMaintainer.java
shidayang
reviewed
Nov 29, 2023
...rver/src/main/java/com/netease/arctic/server/optimizing/maintainer/MixedTableMaintainer.java
Show resolved
Hide resolved
shidayang
reviewed
Nov 29, 2023
...er/src/main/java/com/netease/arctic/server/optimizing/maintainer/IcebergTableMaintainer.java
Outdated
Show resolved
Hide resolved
shidayang
approved these changes
Nov 30, 2023
|
LGTM |
wangtaohz
added a commit
to wangtaohz/amoro
that referenced
this pull request
Dec 20, 2023
zhoujinsong
added a commit
that referenced
this pull request
Dec 21, 2023
…hots with optimized sequence (#2456) * [AMORO-1720] Fix Mixed Format KeyedTable expiring all the snapshots with optimized sequence (#2394) * should not expire the latest snapshot contains optimized sequence * add visible for testing * add fetchLatestNonOptimizedSnapshotTime for base store * get hive locations return the uri path * refactor codes and fix comments * improve for exclude files is empty for expring snapshots --------- Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com> * revert changes introduced from #2328 --------- Co-authored-by: ZhouJinsong <zhoujinsong0505@163.com>
ShawHee
pushed a commit
to ShawHee/arctic
that referenced
this pull request
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Enhance #1960.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation