Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support 404 page for website #460

Closed
liuxiran opened this issue Aug 16, 2021 · 11 comments
Closed

support 404 page for website #460

liuxiran opened this issue Aug 16, 2021 · 11 comments
Labels
SEO
Milestone
V2.3

Comments

@liuxiran
Copy link
Contributor

No description provided.

@liuxiran liuxiran added the SEO label Aug 16, 2021
@Amishakumari544
Copy link

could you please provide any 404 UI @liuxiran or should I design by myself to add this page??

@iamayushdas
Copy link
Contributor

Hi @Amishakumari544, you could explore the apisix website and get some idea about it by yourself.
Also you could comment your designs here for our reviews.
Thanks a lot

@Amishakumari544
Copy link

Hi @iamayushdas I have designed one UI for 404 could please review once if it is ok to code or not???
Link is here:
https://www.figma.com/file/l6aK7cLCDpJWiuzYnu43ZN/Untitled?node-id=101%3A2

@iamayushdas
Copy link
Contributor

Its good, but could you play around with apisix icon in 404 page?

@Amishakumari544
Copy link

like can you give some example I am not getting you what should I change in this?

@iamayushdas
Copy link
Contributor

Lemme cc @liuxiran @juzhiyuan @guoqqqi for review on it

@1502shivam-singh
Copy link
Member

https://www.figma.com/file/l6aK7cLCDpJWiuzYnu43ZN/Untitled?node-id=101%3A2

This looks too generic for reasons -

  • Uses generic stock infographics from free-to-use websites (nothing bad with this), that don't have much correlation with APISIX in general. If you don't want to do something custom or are out of ideas try adding images that have some connection with APISIX's background (you might want to do a bit of research to get a better background)

  • This doesn't really give me the right vibes for a product of the seriousness of APISIX. Ofcourse you can get a bit loose and creative but that would need something different than the provided.

My remark would be, try to play around with the original Page Not Found template used in docusaurus configured websites and make additions to it. Minimalistic and clean design, with subtle interactions would be appreciated given we don't want people to spend hours on our 404-page :P, but still, appreaciate it and move on.

@Amishakumari544
Copy link

ok @1502shivam-singh then can you suggest any website that how should 404 look like this ?
I used this by a free website and redesign it its not the same as looked in the website but please suggest which type of 404 page you want?

@1502shivam-singh
Copy link
Member

I used this by a free website and redesign it its not the same as looked in the website but please suggest which type of 404 page you want?

As I mentioned above, try to play around with the original Page Not Found template used in docusaurus configured websites and make additions to it (To see this page checkout - https://deploy-preview-395--apisix.netlify.app/docs/dashboard/USER_GUIDE, trying making additions to this page).
Minimalistic and clean design, with subtle interactions would be appreciated. For instance, as mentioned above by Ayush, you can do something with APISIX's logo or something of your own is also welcome).

@liuxiran
Copy link
Contributor Author

Agree with @1502shivam-singh, we can first make all the 404 page redirect to the original Page Not Found template, in fact we will see
image
instead of the default 404 page currently

and then welcome to make our 404 page better, thanks

@juzhiyuan juzhiyuan modified the milestones: V2.1, V2.2 Oct 4, 2021
@juzhiyuan juzhiyuan changed the title Add 404 page for website support 404 page for website Oct 4, 2021
@juzhiyuan juzhiyuan modified the milestones: V2.2, V2.3 Oct 4, 2021
SkyeYoung pushed a commit to SkyeYoung/apisix-website that referenced this issue Mar 3, 2022
@liuxiran
feat: support ungroup in manager api (apache#460)
66709c4 
* feat: support ungroup in manager api

* fix: synchronize route group to route

* fix: update test case
SkyeYoung pushed a commit to SkyeYoung/apisix-website that referenced this issue Mar 3, 2022
@LiteSun @Firstsawyou
@nic-chen @rapiz1 @liuxiran @juzhiyuan
fix: checkHostWithSSL with empty hosts (apache#502)
d61a5d9 
* feat: preview pluginchart (apache#456)

* feat: added pluginchart preview in route step4

* feat: change PluginChart to PluginOrchestration

* add tools to check ASF headers in code files. (apache#454)

* chore: remove unnecessary license file (apache#462)

* remove unnecessary license file

* remove unnecessary license file for `api7 dashboard`

* Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file. (apache#461)

* Increase the checking of .conf and .toml files.

* Skip the check of dag-to-lua-1.1/README.md file

* Put the "run Makefile" check before "get lua lib".

* Put the "run Makefile" check before "get lua lib".

* Put the "run Makefile" check before "get lua lib".

Co-authored-by: lin <lin@MBPro.local>

* ci: Add lint (apache#455)

Co-authored-by: Rapiz <code@rapiz.me>

* Feat: dashboard support route group (apache#433)

* feat: route group UI

* feat(route-ui): add routegroup when create route

* fix: add routegroup to route list

* fix: support add routegroup together with route

* fix: route path define error

* feat: trigger redeploy

* fix: update i18n key

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

* feature:Independent license check operation file. (apache#465)

* feat: support ungroup in manager api (apache#460)

* feat: support ungroup in manager api

* fix: synchronize route group to route

* fix: update test case

* feat: add publish status to route in manager api (apache#450)

* feat: add publish status to route in manager api

* fix: update publish and offline route

* feat: add route publish test module

* fix: synchronize content for route publish/offline

* feat(route): add publish and offline to route (apache#451)

* feat(route): add publish and offline to route

* feat: trigger redeploy

* feat: trigger redeploy

* Update Create.tsx

* fix: update refer to the code review

* fix: init status default value

* fix: add a help msg to status Form.Item

Co-authored-by: 琚致远 <juzhiyuan@apache.org>

* feat: remove netlify (apache#472)

* fix: host should not be required (apache#477)

* feat: added new plugin dependency (apache#475)

* feat: added new plugin dependency

* feat: omit shadow var

* feat: omit shadow var

* fix: host should not be required (apache#479)

* fix: host should not be required

* feat: remove required rule

* feat: Route debug (apache#485)

* feat: new api get route and apisix url

* feat: online debug

* fix: update refer to the review, fix logical error as well

* fix: rename getRouteWithApisixUrl

* feat: update plugin (apache#482)

* feat: improve route (apache#483)

* feat: improve step1

* feat: improve step2

* feat: improve createStep4

* feat: improve transform

* fix: event loop

* feat: clean code

* fix: lost route_group info when enable redirect

* feat: UI improve

* fix: checkHostWithSSL with empty hosts

* Update Create.tsx

Co-authored-by: Firstsawyou <52862365+Firstsawyou@users.noreply.github.com>
Co-authored-by: nic-chen <33000667+nic-chen@users.noreply.github.com>
Co-authored-by: lin <lin@MBPro.local>
Co-authored-by: Rapiz <contact@rapiz.me>
Co-authored-by: Rapiz <code@rapiz.me>
Co-authored-by: liuxiran <belovedxixi@126.com>
Co-authored-by: 琚致远 <juzhiyuan@apache.org>
@juzhiyuan
Copy link
Member

Resolved by #1066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SEO
Projects
None yet
Milestone
V2.3
Development

No branches or pull requests
5 participants
@juzhiyuan @liuxiran @iamayushdas @Amishakumari544 @1502shivam-singh