Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: missing JSONSchema validation for plugin attributes #2834

Closed
membphis opened this issue Nov 24, 2020 · 0 comments · Fixed by #2856
Closed

bug: missing JSONSchema validation for plugin attributes #2834

membphis opened this issue Nov 24, 2020 · 0 comments · Fixed by #2856
Assignees
@spacewander
Labels
bug Something isn't working

Comments

@membphis
Copy link
Member

membphis commented Nov 24, 2020 •
edited
Loading

Issue description

Currently, only Route/Service self is checked. The bound Plugins were not be checked now.
That is wrong.

https://github.com/apache/apisix/blob/master/apisix/http/router/radixtree_uri.lua#L118

In this way, when the data plane is running the plug-in, it exits abnormally due to illegal plug-in parameters.

  1. use JSON schema to check the plugin, confirm the input parameters are valid.
  2. set the default value of the plug-in through the JSON schema check.
@membphis membphis added the bug Something isn't working label Nov 24, 2020
@spacewander spacewander self-assigned this Nov 26, 2020
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Nov 26, 2020
@spacewander
fix: validate plugin configuration in the DP
9f24c92 
Fix apache#2834
@spacewander spacewander mentioned this issue Nov 26, 2020
Merged
4 tasks
@nic-chen nic-chen mentioned this issue Nov 26, 2020
Closed
spacewander added a commit to spacewander/incubator-apisix that referenced this issue Nov 27, 2020
@spacewander
fix: validate plugin configuration in the DP
2308af8 
Fix apache#2834
spacewander added a commit that referenced this issue Nov 28, 2020
@spacewander
fix: validate plugin configuration in the DP (#2856)
1c211ff 
Fix #2834
This was referenced Dec 2, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spacewander spacewander

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: validate plugin configuration in the DP spacewander/incubator-apisix
2 participants
@spacewander @membphis