fix: validate plugin configuration in the DP #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow, That is a nice PR |
|
@spacewander Please update the checklist |
|
@spacewander you can continue this issue |
spacewander
force-pushed
the
validate
branch
from
9f24c92
to
2308af8
Compare
spacewander
force-pushed
the
validate
branch
from
8ce4c12
to
0e00766
Compare
membphis
approved these changes
Nov 27, 2020
tokers
reviewed
Nov 27, 2020
apisix/core/config_etcd.lua
Outdated
| data_valid, err = self.checker(item.value) | ||
| if not data_valid then | ||
| log.error("failed to check item data of [", self.key, | ||
| "] err:", err, " ,val: ", json.delay_encode(item.value)) |
apisix/plugin.lua
Outdated
| @@ -498,4 +498,102 @@ function _M.get(name) | |||
| end | |||
|
|
|||
|
|
|||
| local function check_schema(plugins_conf, schema_type, skip_disabled_plugin) | |||
| for name, plugin_conf in pairs(plugins_conf) do | |||
| core.log.info("check plugin scheme, name: ", name, ", configurations: ", | |||
apisix/plugin.lua
Outdated
|
|
||
| local function stream_check_schema(plugins_conf, schema_type, skip_disabled_plugin) | ||
| for name, plugin_conf in pairs(plugins_conf) do | ||
| core.log.info("check stream plugin scheme, name: ", name, |
moonming
approved these changes
Nov 28, 2020
This was referenced Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2834
What this PR does / why we need it:
Pre-submission checklist: