-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: As a user, I want to refactor the resources under apisix.admin, so that we don't need to repeat #8569
Comments
This was referenced Jan 4, 2023
I think we can refactor the resources one by one:
|
We can use fewer PRs to implement it. The refactor progress can be faster after several PRs as we will have a stable foundation. What about refactoring 2~3 resources in the upcoming PR? |
spacewander
pushed a commit
that referenced
this issue
Jan 12, 2023
12 tasks
7 tasks
The Maybe it is NOT need to be refactored. @spacewander Can we remove it from the list? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently, all the resources under
apisix.admin
are basically copied and pasted from a template and changed. If you make general changes to the resource, such as fix count or add adapter, you need to change it file by file. And due to historical problems, some resource implementation methods are incomplete.I hope we can refactor the code to something like
core.config.new
, where we only need to pass a few parameters to create a new resource.Note: Please read every resource file before jumping into the refactor. Some resources have particular logic. We need a smart way to handle them.
CC @An-DJ
The text was updated successfully, but these errors were encountered: