refactor(admin): secrets and ssls #8911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An-DJ
changed the title
An-DJ
changed the title
spacewander
reviewed
Feb 24, 2023
spacewander
reviewed
Feb 28, 2023
| @@ -148,23 +233,36 @@ function _M:put(id, conf, sub_path, args) | |||
| end | |||
|
|
|||
|
|
|||
| function _M:delete(id) | |||
| function _M:delete(id, conf, sub_path) | |||
There was a problem hiding this comment.
Why do we need to pass conf in this method?
There was a problem hiding this comment.
@spacewander We should Keep all methods in the same form.
https://github.com/apache/apisix/blob/master/apisix/admin/init.lua#L220
The meaningful first param is id, the second one is conf, and the third one is the sub_path.
Should we?
There was a problem hiding this comment.
Let's add a comment that explains why we need a placeholder conf here.
spacewander
approved these changes
Mar 1, 2023
soulbird
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continue to review this work after #8820 is merged.
Refactor secrets and ssls.
All admin.resources is refactored.
Close #8569
Checklist