Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update install-dependencies.md doc #3645

Closed
wants to merge 1 commit into from

Conversation

Firstsawyou
Copy link
Contributor

What this PR does / why we need it:

The Mac OSX environment lacks the installation steps of LuaRocks. so it needs to be added.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@@ -150,6 +150,9 @@ nohup etcd &
# install OpenResty, etcd and some compilation tools
brew install openresty/brew/openresty etcd luarocks curl git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be removed
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure that the installed version of LuaRocks is correct, I think it should be added. This is an error problem encountered when installing according to the document:

截屏2021-02-23 下午7 18 18

截屏2021-02-23 下午7 19 56

截屏2021-02-23 下午7 42 04

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we will install luarocks from source, I think it can be removed.

@Firstsawyou
Copy link
Contributor Author

It has been fixed by #3718.

@Firstsawyou Firstsawyou closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants