Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail to run make deps on macOS #3718

Merged
merged 9 commits into from
Mar 8, 2021

Conversation

nic-chen
Copy link
Member

@nic-chen nic-chen commented Mar 1, 2021

What this PR does / why we need it:

fix script and docs about install dependencies on macOS

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@nic-chen nic-chen marked this pull request as ready for review March 2, 2021 08:27
Makefile Show resolved Hide resolved
@@ -150,7 +150,10 @@ nohup etcd &

```shell
# install OpenResty, etcd and some compilation tools
brew install openresty/brew/openresty etcd luarocks curl git
brew install openresty/brew/openresty openresty-openssl111 etcd curl git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember openresty-openssl111 is a dependency of openresty, will it be installed automatically?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, or-openssl111 will be autoaticll installed when you install openresty

@nic-chen
Copy link
Member Author

nic-chen commented Mar 3, 2021

will update later

Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the mac os scenario, we should do this:

  1. Install lua 5.1: brew install lua@5.1
  2. When calling the luarocks command in make deps, add the parameter --lua-dir=/usr/local/opt/lua@5.1, eg: luarocks --lua-dir=/usr/local/opt/lua@5.1 ***

@nic-chen
Copy link
Member Author

nic-chen commented Mar 5, 2021

In the mac os scenario, we should do this:

  1. Install lua 5.1: brew install lua@5.1

  2. When calling the luarocks command in make deps, add the parameter --lua-dir=/usr/local/opt/lua@5.1, eg: luarocks --lua-dir=/usr/local/opt/lua@5.1 ***

we use utils/linux-install-luarocks.sh to install luarocks, so we use luajit for luarock, and don't need to set lua 5.1 for it. @membphis

@nic-chen
Copy link
Member Author

nic-chen commented Mar 8, 2021

In the mac os scenario, we should do this:

  1. Install lua 5.1: brew install lua@5.1
  2. When calling the luarocks command in make deps, add the parameter --lua-dir=/usr/local/opt/lua@5.1, eg: luarocks --lua-dir=/usr/local/opt/lua@5.1 ***

update to use brew to install luarocks.

please have a look when you have time. @membphis

Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@totemofwolf welcome to take a look and make a try with this PR, it should work for mac os.

@spacewander spacewander merged commit fc9fcff into apache:master Mar 8, 2021
@nic-chen nic-chen deleted the mac-install-issue branch March 22, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants