-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dash in args (#4519) #4676
Conversation
Co-authored-by: Alex Zhang <tokers@apache.org>
Co-authored-by: Alex Zhang <tokers@apache.org>
Please merge master to make CI pass. |
Some conflicts should be solved, i will fix it |
CI fail refering to error log
I think it should pass api_ctx to ngx.ctx in the /admin/init.lua
Do I need to fit this in this pr? |
@nanamikon |
All tests pass now |
We can remove the 'arg' part from 'TEST 2: http header + arg' |
Get it |
Err... We still need the "TEST 2: http header" but remove the arg part of it. |
Sorry for misunderstanding, I will fix it |
Co-authored-by: tzssangglass <tzssangglass@gmail.com>
What this PR does / why we need it:
Support fetch value from arg name with dash , see #4519
Pre-submission checklist: