feat: support dash in args (#4519)

apisix/core/ctx.lua

@@ -159,7 +159,18 @@ do
                     val, err = cookie:get(sub_str(key, 8))
                     if err then
                         log.warn("failed to fetch cookie value by key: ",
-                                 key, " error: ", err)
+                                key, " error: ", err)
+                    end
+                end
+
+            elseif core_str.has_prefix(key, "arg_") then
+                local arg_key = sub_str(key, 5)
+                local args = request.get_uri_args()[arg_key]
+                if args then
+                    if type(args) == "table" then
+                        val = args[1]
+                    else
+                        val = args
                     end
                 end
 

t/core/ctx2.t

@@ -136,3 +136,69 @@ qr/balancer_ip: 127.0.0.1|balancer_port: 1980/
 --- grep_error_log_out
 balancer_ip: 127.0.0.1
 balancer_port: 1980
+
+
+
+=== TEST 5: support dash in the args
+--- config
+    location /t {
+        content_by_lua_block {
+            local core = require("apisix.core")
+            local ngx_ctx = ngx.ctx
+            local api_ctx = ngx_ctx.api_ctx
+            if api_ctx == nil then
+                api_ctx = core.tablepool.fetch("api_ctx", 0, 32)
+                ngx_ctx.api_ctx = api_ctx
+            end
+            core.ctx.set_vars_meta(api_ctx)
+            ngx.say("arg_a-b: ", api_ctx.var["arg_a-b"])
+        }
+    }
+--- request
+GET /t?a-b=aaa
+--- response_body
+arg_a-b: aaa
+
+
+
+=== TEST 6: support dash in the args(Multi args with the same name, only fetch the first one)
+--- config
+    location /t {
+        content_by_lua_block {
+            local core = require("apisix.core")
+            local ngx_ctx = ngx.ctx
+            local api_ctx = ngx_ctx.api_ctx
+            if api_ctx == nil then
+                api_ctx = core.tablepool.fetch("api_ctx", 0, 32)
+                ngx_ctx.api_ctx = api_ctx
+            end
+            core.ctx.set_vars_meta(api_ctx)
+            ngx.say("arg_a-b: ", api_ctx.var["arg_a-b"])
+        }
+    }
+--- request
+GET /t?a-b=aaa&a-b=bbb
+--- response_body
+arg_a-b: aaa
+
+
+
+=== TEST 7: support dash in the args(arg is missing)
+--- config
+    location /t {
+        content_by_lua_block {
+            local core = require("apisix.core")
+            local ngx_ctx = ngx.ctx
+            local api_ctx = ngx_ctx.api_ctx
+            if api_ctx == nil then
+                api_ctx = core.tablepool.fetch("api_ctx", 0, 32)
+                ngx_ctx.api_ctx = api_ctx
+            end
+            core.ctx.set_vars_meta(api_ctx)
+            ngx.say("arg_a-b: ", api_ctx.var["arg_a-b"])
+        }
+    }
+--- request
+GET /t
+--- response_body
+arg_a-b: nil