test(csharp/test/Drivers/Snowflake): Adding numeric value tests #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flakeNumericTests
…flakeNumericTests
…flakeNumericTests
…flakeNumericTests
…flakeNumericTests
…rename create table to create temp table
…flakeNumericTests
|
Can you rebase from master instead of merging the changes? Otherwise the PR in GitHub has more changes than we want. |
…ADME, generify expected table name in CanClientExecuteUpdateUsingExecuteReader test (apache#1240) README currently lists the field name as "database", when it should be "catalog". Also add a few small notes that the config file is JSON and there's a template in resources to use. CanClientExecuteUpdateUsingExecuteReader() currently has the table name ADBC_ALLTYPES hardcoded, ignoring the table value set in the configuration. It can be made to use the config table name instead.
This PR: - Adds support for SqlDecimal for Decimal128 (follow up to apache/arrow#38481) - Treats Decimal256 values as string (follow up to apache/arrow#38508) - Adds a new DecimalBehavior to the Client to allow the caller to determine how to treat decimal values - Standardizes the test frameworks to Xunit Addresses apache#1230 --------- Co-authored-by: David Coe <coedavid@umich.edu>
…oes not contain sqlite3_load_extension() (apache#1259) Closes apache#1255.
… when fetching string option (apache#1258) Closes apache#1256; closes apache#1129.
….dll (apache#1295) Test dependency is not required for product code.
…#1290) # What? Add implementation for `GetObjects` in CGO wrapper for `adbc_driver_manager` # Why? Functionality exists in C++ driver manager but not yet accessible via Go driver interface. # Notes I haven't worked with CGO before so I wanted to limit the scope of this PR to just one of the unimplemented methods in the wrapper. I would like to continue implementing the other methods once I know I'm going about this correctly. Closes part of apache#1291
…pache#1298) In sync with arrow-glib, GADBC should name its Vala's VAPI file's name to adbc-glib and is the same as the pkg-config adbc-glib.pc file's name https://wiki.gnome.org/Projects/Vala/LibraryWritingNamingAndBuilding > The name of the VAPI file should be the same as the pkg-config file for the library.
This PR: - Adds support for SqlDecimal for Decimal128 (follow up to apache/arrow#38481) - Treats Decimal256 values as string (follow up to apache/arrow#38508) - Adds a new DecimalBehavior to the Client to allow the caller to determine how to treat decimal values - Standardizes the test frameworks to Xunit Addresses apache#1230 --------- Co-authored-by: David Coe <coedavid@umich.edu>
…rename create table to create temp table
…s/arrow-adbc into snowflakeNumericTests
|
Think my rebasing messed up the branch, may just make a new PR that's cleaner... |
CurtHagenlocher
pushed a commit
that referenced
this pull request
Nov 17, 2023
Adding tests which do a simple insert, select and delete for the numeric data types in Snowflake, to validate that they can be added and read correctly through ADBC. The target values are usually problematic for reading and writing, such as infinity, min and max values and NaN, but some more standard values are included for sanity. Tests structure: 1. Create a temporary table with a single column of the chosen numeric data type. Snowflake has effectively two: NUMBER and FLOAT, with NUMBER having variations depending on the precision and scale. The table will use the config specified catalog and schema, but the table itself will be a generated name to avoid collisions or overwriting other data. 2. A single value of the correct type is inserted into the table. 3. The value is queried from the table, and validated for correctness. 4. The row is deleted from the table, using the value in the WHERE clause. Remake of #1274
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests which do a simple insert, select and delete for the numeric data types in Snowflake, to validate that they can be added and read correctly through ADBC. The target values are usually problematic for reading and writing, such as infinity, min and max values and NaN, but some more standard values are included for sanity.
Tests structure: