fix(csharp/drivers/bigquery): add back support for Struct and List arrays #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
CurtHagenlocher
approved these changes
Nov 10, 2023
|
It would be good to have a test which exercises this, perhaps as a followup. It shouldn't be necessary to create a table for that; you can generally just return literals or constructed values from a SELECT statement. |
This was referenced Nov 10, 2023
CurtHagenlocher
pushed a commit
that referenced
this pull request
Nov 13, 2023
- Add support for dynamic data that can execute against data sources without physical tables - Add data for tests of issues previously found in BigQuery and Snowflake - Refactor common functionality into the Apache.Arrow.Adbc.Tests project from the respective drivers Addresses #1282 (comment) --------- Co-authored-by: David Coe <coedavid@umich.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
got a little too crazy with the refactoring and missed the List and Struct types for BigQuery