Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csharp/drivers/bigquery): add back support for Struct and List arrays #1282

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

davidhcoe
Copy link
Contributor

got a little too crazy with the refactoring and missed the List and Struct types for BigQuery

Copy link

⚠️ Please follow the Conventional Commits format in CONTRIBUTING.md for PR titles.

@CurtHagenlocher
Copy link
Contributor

It would be good to have a test which exercises this, perhaps as a followup. It shouldn't be necessary to create a table for that; you can generally just return literals or constructed values from a SELECT statement.

@CurtHagenlocher CurtHagenlocher merged commit ff222e2 into apache:main Nov 10, 2023
2 checks passed
CurtHagenlocher pushed a commit that referenced this pull request Nov 13, 2023
- Add support for dynamic data that can execute against data sources
without physical tables
- Add data for tests of issues previously found in BigQuery and
Snowflake
- Refactor common functionality into the Apache.Arrow.Adbc.Tests project
from the respective drivers

Addresses
#1282 (comment)

---------

Co-authored-by: David Coe <coedavid@umich.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants