Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(format): correct duplicated statistics names #1736

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

lidavidm
Copy link
Member

Fixes #1688.

@github-actions github-actions bot added this to the ADBC Libraries 1.0.0 milestone Apr 19, 2024
@lidavidm lidavidm marked this pull request as ready for review April 19, 2024 05:39
Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should these also show up in the python options too?

@lidavidm
Copy link
Member Author

We don't have a Python enum for these (un)fortunately

@lidavidm lidavidm merged commit 75a4b64 into apache:main Apr 22, 2024
64 of 67 checks passed
@lidavidm lidavidm deleted the gh-1688 branch April 22, 2024 01:48
cocoa-xu pushed a commit to cocoa-xu/arrow-adbc that referenced this pull request Apr 24, 2024
davidhcoe pushed a commit to davidhcoe/arrow-adbc that referenced this pull request Apr 25, 2024
cocoa-xu pushed a commit to meowcraft-dev/arrow-adbc that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format: duplicated statistics names
2 participants