Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(format): correct duplicated statistics names #1736

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix(format): correct duplicated statistics names #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions adbc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,15 +546,15 @@ const struct AdbcError* AdbcErrorFromArrayStream(struct ArrowArrayStream* stream
/// (when approximate).
///
/// For example, this is the maximum length of a string for a string column.
#define ADBC_STATISTIC_MAX_BYTE_WIDTH_NAME "adbc.statistic.byte_width"
#define ADBC_STATISTIC_MAX_BYTE_WIDTH_NAME "adbc.statistic.max_byte_width"
/// \brief The dictionary-encoded name of the max value statistic.
#define ADBC_STATISTIC_MAX_VALUE_KEY 3
/// \brief The max value statistic. Value type is column-dependent.
#define ADBC_STATISTIC_MAX_VALUE_NAME "adbc.statistic.byte_width"
#define ADBC_STATISTIC_MAX_VALUE_NAME "adbc.statistic.max_value"
/// \brief The dictionary-encoded name of the min value statistic.
#define ADBC_STATISTIC_MIN_VALUE_KEY 4
/// \brief The min value statistic. Value type is column-dependent.
#define ADBC_STATISTIC_MIN_VALUE_NAME "adbc.statistic.byte_width"
#define ADBC_STATISTIC_MIN_VALUE_NAME "adbc.statistic.min_value"
/// \brief The dictionary-encoded name of the null count statistic.
#define ADBC_STATISTIC_NULL_COUNT_KEY 5
/// \brief The null count statistic. The number of values that are null in
Expand Down
6 changes: 3 additions & 3 deletions go/adbc/adbc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,15 +287,15 @@ const (
// approximate).
//
// For example, this is the maximum length of a string for a string column.
StatisticMaxByteWidthName = "adbc.statistic.byte_width"
StatisticMaxByteWidthName = "adbc.statistic.max_byte_width"
// The dictionary-encoded name of the max value statistic.
StatisticMaxValueKey = 3
// The max value statistic. Value type is column-dependent.
StatisticMaxValueName = "adbc.statistic.byte_width"
StatisticMaxValueName = "adbc.statistic.max_value"
// The dictionary-encoded name of the min value statistic.
StatisticMinValueKey = 4
// The min value statistic. Value type is column-dependent.
StatisticMinValueName = "adbc.statistic.byte_width"
StatisticMinValueName = "adbc.statistic.min_value"
// The dictionary-encoded name of the null count statistic.
StatisticNullCountKey = 5
// The null count statistic. The number of values that are null in the
Expand Down
6 changes: 3 additions & 3 deletions go/adbc/drivermgr/adbc.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions java/core/src/main/java/org/apache/arrow/adbc/core/StandardStatistics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ public enum StandardStatistics {
*
* <p>For example, this is the maximum length of a string for a string column.
*/
MAX_BYTE_WIDTH("adbc.statistic.byte_width", (short) 2),
MAX_BYTE_WIDTH("adbc.statistic.max_byte_width", (short) 2),
/** The max value statistic. Value type is column-dependent. */
MAX_VALUE("adbc.statistic.byte_width", (short) 3),
MAX_VALUE("adbc.statistic.max_value", (short) 3),
/** The min value statistic. Value type is column-dependent. */
MIN_VALUE("adbc.statistic.byte_width", (short) 4),
MIN_VALUE("adbc.statistic.min_value", (short) 4),
/**
* The null count statistic. The number of values that are null in the column. Value type is int64
* (when not approximate) or float64 (when approximate).
Expand Down
Loading