chore(r): Update CI setup to silence warnings for Go-based drivers #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
I don't think we did anything recently but I wouldn't be surprised if the Go runtime calls abort in some circumstances. I wonder if we could just interpose the symbol somehow to call R instead? |
lidavidm
approved these changes
Apr 15, 2025
Member
Author
|
That sounds hard, but good to know there's an option! The driver packages have very little R code and so the WARNINGs aren't really catching anything anyway (the mostly likely thing that those checks are catching are things that will cause those drivers to stop building or loading, which would be ERRORs). |
colin-rogers-dbt
pushed a commit
to dbt-labs/arrow-adbc
that referenced
this pull request
Jun 10, 2025
…pache#2708) Closes apache#2707. This is more likely to be a change in Adbc somewhere since it's showing up in all versions. Did we add anything recently that logged anything to stderr or called assert or abort? In the event it can't be avoided (it often can't), we can update the warning fail level for go-based drivers since we don't distribute them on CRAN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2707.
This is more likely to be a change in Adbc somewhere since it's showing up in all versions. Did we add anything recently that logged anything to stderr or called assert or abort?
In the event it can't be avoided (it often can't), we can update the warning fail level for go-based drivers since we don't distribute them on CRAN.