Skip to content

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Jun 29, 2025

Fix #3059 (Supersede #2708)

@eitsupi
Copy link
Contributor Author

eitsupi commented Jun 29, 2025

(I just wanted to make sure this solution works)

@eitsupi
Copy link
Contributor Author

eitsupi commented Jun 29, 2025

@paleolimbot As far as I can see the difference in the logs between adbcsnowflake (nothing) and adbcflightsql (changed), does this change seem to work well?

* checking compiled code ... WARNING
Warning: File ‘adbcsnowflake/libs/adbcsnowflake.so’:
  Found ‘abort’, possibly from ‘abort’ (C)
    Object: ‘go/libadbc_driver_snowflake.a’
  Found ‘stderr’, possibly from ‘stderr’ (C)
    Object: ‘go/libadbc_driver_snowflake.a’

https://github.com/apache/arrow-adbc/actions/runs/15954167507/job/44998244253?pr=3061

 * checking compiled code ... OK

https://github.com/apache/arrow-adbc/actions/runs/15954167507/job/44998244254?pr=3061

@paleolimbot
Copy link
Member

This works for me!

@eitsupi eitsupi changed the title fix(r/adbcflightsql): fix warnings on R CMD check for Go-based drivers fix(r/adbcbigquery,r/adbcflightsql,r/adbcsnowflake): fix warnings on R CMD check for Go-based drivers Jul 1, 2025
@eitsupi eitsupi marked this pull request as ready for review July 1, 2025 13:24
@github-actions github-actions bot added this to the ADBC Libraries 19 milestone Jul 1, 2025
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this properly! This particular CRAN rule is I think one of their worst additions to date (actively making it harder to package useful libraries to R 🙁 ). Just one optional request to document why we need the extra makefile target but in general this looks great!

Comment on lines +30 to +32
purify: $(SHLIB)
rm -Rf "$(CURDIR)/go/libadbc_driver_snowflake.a"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note (here and to the other files) about why we have to do this? (Mostly so I don't forget the next time I look here 😬 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about 9c63bfa?

@eitsupi
Copy link
Contributor Author

eitsupi commented Jul 1, 2025

This is a side note, but I noticed that only adbcsnowflake does not have Makevars.win.
Can we remove Makevars.win from drivers other than adbcsnowflake? Or, we should add that file to adbcsnowflake?

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paleolimbot paleolimbot merged commit d212b82 into apache:main Jul 2, 2025
26 checks passed
@paleolimbot
Copy link
Member

Can we remove Makevars.win from drivers other than adbcsnowflake?

Yes, we can. The Go drivers don't build without the UCRT R versions (although I think Snowflake did at one point, hence the file).

@eitsupi eitsupi deleted the fix-r-warn branch July 2, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

r: Go-based drivers are warned by macOS R CMD check on R-universe

2 participants