Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Followup tasks for nanvl #7311

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Minor: Followup tasks for nanvl #7311

merged 1 commit into from
Aug 16, 2023

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Aug 16, 2023

Closes #7310

Rationale for this change

nanvl was added in #7171 but some additional change needed.
One is adding an entry to the function list table in user-guide/expressions.md for nanvl.
Another is modifying the error message in tests newly added to math_expressions.rs.

What changes are included in this PR?

This PR added an entry to the function list table for nanvl and fix the error message in math_expressions.rs.

Are these changes tested?

Existing tests pass with cargo test --workspace.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the physical-expr Changes to the physical-expr crates label Aug 16, 2023
@sarutak sarutak changed the title Follorup tasks for nanvl Followup tasks for nanvl Aug 16, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sarutak

@alamb alamb changed the title Followup tasks for nanvl Minor: Followup tasks for nanvl Aug 16, 2023
@alamb alamb merged commit d2f9025 into apache:main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Changes to the physical-expr crates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Followup tasks for nanvl
2 participants