Solving #293 #297
Closed
Solving #293 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
With an alternative solution #298, changes from #296 are removed from this PR, now it's only about I suggest the commit history should be squashed, but don't have experience how to do that from my side, only seeing articles suggesting "Squash and merge" option of Github, but that seems only doable when merging a PR. |
|
Sorry for never getting to review/support this. I agree the functionality is good and this was a good start. Instead of returning a tuple of tables, I opted for a more lazy approach of just defining a custom iterator + tests: #443 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to solve #293, implementing
Tables.partitions()forArrow.Tableturns out trivial enough, though I'm not clear what to do about companion test cases, documentation etc.I'm lazy to have not excluded #296 from this PR, I'm open to draft another PR separated if you'd like, but the change set seems small, I hope you can have a quick look and decide what to do next.