Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getproperty instead of type parameter to get names #415

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Use getproperty instead of type parameter to get names #415

merged 3 commits into from
Apr 7, 2023

Conversation

simsurace
Copy link
Contributor

@simsurace simsurace commented Apr 6, 2023 •
edited
Loading

Closes #414

Tables.Schema does not store names in the type parameters if there are more than (2^16) - 1 columns:

https://github.com/JuliaData/Tables.jl/blob/2cb13998e856692ed273c931b83477caf8b7b020/src/Tables.jl#L477-L483

@ericphanson
Copy link
Member

Can you add a test?

@simsurace
Copy link
Contributor Author

Sure. What do we want to test exactly? To prevent #414 we would need a table type that allows for >65535 columns.

@ericphanson
Copy link
Member

Maybe this one? https://tables.juliadata.org/dev/#Tables.table

@simsurace
Copy link
Contributor Author

Unfortunately (and maybe this is a bug in Tables.jl) Tables.schema(::MatrixTable) stores the names in the type parameter, so it won't expose the problem in #414.

@ericphanson
Copy link
Member

Ah that does sound like a bug. Well, we can add a test-only dependency on DataFrames by adding it to extras & the test target in the Project.toml

@simsurace simsurace mentioned this pull request Apr 6, 2023
Open
@simsurace
Copy link
Contributor Author

@ericphanson I added a test as suggested by you.

ericphanson
ericphanson reviewed Apr 6, 2023
View reviewed changes
test/runtests.jl Outdated Show resolved Hide resolved
@ericphanson ericphanson merged commit c469151 into apache:main Apr 7, 2023
@simsurace
Copy link
Contributor Author

Thanks for getting this merged quickly. What is the release cycle? Can we get this released as a patch?

@ericphanson
Copy link
Member

There is a process documented partly here: https://github.com/apache/arrow-julia/tree/main/dev/release. It takes a day or two since there needs to be a vote. Can you PR a patch bump to get it started? We can ask @kou if they are willing to work on the next steps after.

@simsurace
Copy link
Contributor Author

I'll do that once I get back to my computer.

@simsurace simsurace deleted the 65535cols branch April 11, 2023 09:41
@simsurace simsurace mentioned this pull request Apr 11, 2023
Merged
baumgold pushed a commit that referenced this pull request Apr 11, 2023
@simsurace
Bump patch version (#423)
22088f1 
This is to get #415 released to allow writing wide (more than 65535
columns) tables to Arrow.

@kou, could you take it from here?
Moelf pushed a commit to Moelf/arrow-julia that referenced this pull request Apr 13, 2023
@simsurace @Moelf
Bump patch version (apache#423)
1c57a4d 
This is to get apache#415 released to allow writing wide (more than 65535
columns) tables to Arrow.

@kou, could you take it from here?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericphanson ericphanson ericphanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does Arrow.write have an upper limit for the number of columns?
2 participants
@simsurace @ericphanson