Skip to content

Commit

Permalink
Fix parquet benchmarks (#1723)
Browse files Browse the repository at this point in the history
* Fix parquet benchmarks

* Format
  • Loading branch information
tustvold authored May 24, 2022
1 parent 4467a3a commit a14a1d3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ jobs:
run: |
export CARGO_HOME="/github/home/.cargo"
export CARGO_TARGET_DIR="/github/home/target"
cargo check --benches --workspace
cargo check --benches --workspace --features test_common,prettyprint,async,experimental
lint:
name: Lint (cargo fmt)
Expand Down
7 changes: 2 additions & 5 deletions parquet/benches/arrow_reader.rs
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,7 @@ where
let mut pages: Vec<Vec<parquet::column::page::Page>> = Vec::new();
for _i in 0..NUM_ROW_GROUPS {
let mut column_chunk_pages = VecDeque::new();
let mem_tracker = Arc::new(parquet::memory::MemTracker::new());
let mut dict_encoder = DictEncoder::<T>::new(column_desc.clone(), mem_tracker);
let mut dict_encoder = DictEncoder::<T>::new(column_desc.clone());
// add data pages
for _j in 0..PAGES_PER_GROUP {
// generate page
Expand Down Expand Up @@ -239,9 +238,7 @@ fn build_dictionary_encoded_string_page_iterator(
let mut pages: Vec<Vec<parquet::column::page::Page>> = Vec::new();
for _i in 0..NUM_ROW_GROUPS {
let mut column_chunk_pages = VecDeque::new();
let mem_tracker = Arc::new(parquet::memory::MemTracker::new());
let mut dict_encoder =
DictEncoder::<ByteArrayType>::new(column_desc.clone(), mem_tracker);
let mut dict_encoder = DictEncoder::<ByteArrayType>::new(column_desc.clone());
// add data pages
for _j in 0..PAGES_PER_GROUP {
// generate page
Expand Down

0 comments on commit a14a1d3

Please sign in to comment.