Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Zero-Copy Conversion from Vec to/from MutableBuffer #3516

Closed
tustvold opened this issue Jan 12, 2023 · 1 comment · Fixed by #3756 or #3920
Closed

Support Zero-Copy Conversion from Vec to/from MutableBuffer #3516

tustvold opened this issue Jan 12, 2023 · 1 comment · Fixed by #3756 or #3920
Assignees
@tustvold
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

This will allow better interoperability with the rest of the ecosystem, and meshes well with the work by @viirya to provide fallible conversion from Buffer to MutableBuffer as part of #1981

Describe the solution you'd like

I would like From implementations to allow conversion between Vec<A: ArrowNativeType> and MutableBuffer. Much like typed_data_mut these will panic if alignment constraints are violated.

Describe alternatives you've considered

Additional context
@tustvold tustvold added the enhancement Any new improvement worthy of a entry in the changelog label Jan 12, 2023
@tustvold tustvold self-assigned this Jan 12, 2023
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jan 12, 2023
@tustvold
Add Global deallocation variant (apache#3516)
f06d9d2
@tustvold tustvold mentioned this issue Jan 12, 2023
Closed
tustvold added a commit to tustvold/arrow-rs that referenced this issue Feb 23, 2023
@tustvold
Zero-copy Vec conversion (apache#3516) (apache#1176)
7e7fb64
tustvold added a commit to tustvold/arrow-rs that referenced this issue Feb 23, 2023
@tustvold
Zero-copy Vec conversion (apache#3516) (apache#1176)
4cbad4d
@tustvold tustvold mentioned this issue Feb 23, 2023
Merged
tustvold added a commit that referenced this issue Mar 1, 2023
@tustvold
Zero-copy Vec conversion (#3516) (#1176) (#3756)
d440c24 
* Zero-copy Vec conversion (#3516) (#1176)

* Fix doc

* More tests

* Review feedback

* More tests
@tustvold tustvold added the arrow Changes to the arrow crate label Mar 10, 2023
@tustvold
Copy link
Contributor Author

label_issue.py automatically added labels {'arrow'} from #3756

@tustvold tustvold mentioned this issue Mar 23, 2023
Merged
@tustvold tustvold reopened this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tustvold tustvold

Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
1 participant
@tustvold