Add Global deallocation variant (#3516) #3517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jan 12, 2023
| @@ -135,20 +135,25 @@ pub(crate) enum Deallocation { | |||
| /// An allocation of the given capacity that needs to be deallocated using arrows's cache aligned allocator. | |||
| /// See [allocate_aligned] and [free_aligned]. | |||
| Arrow(usize), | |||
There was a problem hiding this comment.
Eventually I could see us removing this in favor of Global, but I kept it for now
tustvold
commented
Jan 12, 2023
| /// An allocation from an external source like the FFI interface or a Rust Vec. | ||
| /// Deallocation will happen | ||
| /// An allocation using the system's default global allocator and the provided layout | ||
| Global(Layout), |
There was a problem hiding this comment.
This does increase the size of Dellocation by 8 bytes. In practice this is extremely unlikely to matter
viirya
approved these changes
Jan 12, 2023
viirya
reviewed
Jan 12, 2023
|
I need to think a bit more on this, the challenge is Vec will call dealloc with the alignment it would ask for, not the alignment that is actually correct 🤔 |
|
I plan to handle this differently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3516
Rationale for this change
This is the first part of supporting zero-copy conversion between
VecandMutableBuffer. Crucially we need to carry along theLayoutas it is UB to call realloc or dealloc with a different layout from the one provided to the initial call toalloc.What changes are included in this PR?
Are there any user-facing changes?