Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV Reader Doesn't set Timezone #3841

Closed
tustvold opened this issue Mar 10, 2023 · 0 comments · Fixed by #3908
Closed

CSV Reader Doesn't set Timezone #3841

tustvold opened this issue Mar 10, 2023 · 0 comments · Fixed by #3908
Labels
arrow Changes to the arrow crate bug

Comments

@tustvold
Copy link
Contributor

Describe the bug

Bug I noticed whilst reviewing #3835 and looking at what the CSV reader is doing.

In particular it collects into a PrimitiveArray<T> which will set the data type to be ArrowPrimitiveType::DATA_TYPE, which will have a timezone of None.

In addition it does not contain the necessary logic to correctly interpret timezones, as this was only added in #3795

To Reproduce

Expected behavior

Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate bug
Projects
None yet
Milestone
No milestone
1 participant
@tustvold