Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timestamp/time and date json decoding #3835

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

spebern
Copy link
Contributor

@spebern spebern commented Mar 9, 2023

Which issue does this PR close?

Closes #3834.

Rationale for this change

What changes are included in this PR?

Support json decoding of

  • Time32
  • Time64
  • Timestamp
  • Date32
  • Date64
    in raw decoder.

Are there any user-facing changes?

The previous json reader was a little bit more flexible, because it supported passing format strings:

format_strings: Option<HashMap<String, String>>,

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 9, 2023
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me

@spebern
Copy link
Contributor Author

spebern commented Mar 10, 2023

Thanks for your work on the raw decoder. It is really easy to add support for new types.

arrow-json/src/raw/mod.rs Outdated Show resolved Hide resolved
Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@tustvold tustvold merged commit 61c4f12 into apache:master Mar 10, 2023
@ursabot
Copy link

ursabot commented Mar 10, 2023

Benchmark runs are scheduled for baseline = 495682a and contender = 61c4f12. 61c4f12 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@tustvold
Copy link
Contributor

FYI added timezone support in #3845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support timestamp/time and date types in json decoder
3 participants